Move old router tests to new directory and skip#1901
Merged
dannyprikaz merged 1 commit intohackforla:developmentfrom Apr 10, 2025
Merged
Move old router tests to new directory and skip#1901dannyprikaz merged 1 commit intohackforla:developmentfrom
dannyprikaz merged 1 commit intohackforla:developmentfrom
Conversation
Member
Re: this, I found that when I added a step to check on the staged changes before committing, less unintentional code got into my PRs. Current workflow for me looks like:
If that's helpful, great! If it was just a fluke, please disregard :) |
trillium
approved these changes
Apr 9, 2025
Member
trillium
left a comment
There was a problem hiding this comment.
Approved! Thanks for getting this process going @dannyprikaz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1898
What changes did you make and why did you make them ?
routersdirectory totest/old-testsjest.config.jsto ignore the path to that new directoryglobalConfig.jsonwas also changed. This should have been in the gitignore, but it will be deleted soon.