enable enter key submission on login#1933
Merged
angela-lee1 merged 6 commits intohackforla:developmentfrom May 28, 2025
Merged
Conversation
trillium
requested changes
May 19, 2025
Member
trillium
left a comment
There was a problem hiding this comment.
He Angela, thanks for your work here.
This looks a little overengineered, overall we prefer to continue to use built in HMTL functionality to submit the form. It looks like we just need to wrap the FormControl component and a form component and then we should be good.
Make sure to move the properties from the FormControl component into the form component
// Move from <FormControl> to <form>
onSubmit={handleLogin}
className="form-check-in"
autoComplete="off"…forms update feature branch
…ogin-forms' into enable-enter-key-submission-on-login-forms i# update feature branch
Member
Author
trillium
approved these changes
May 27, 2025
Member
trillium
left a comment
There was a problem hiding this comment.
Thanks for making these changes, approved :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1919
What changes did you make and why did you make them?