Unit testing for User model#1955
Merged
dannyprikaz merged 9 commits intohackforla:developmentfrom Jul 29, 2025
Merged
Conversation
dannyprikaz
requested changes
Jun 17, 2025
Member
dannyprikaz
left a comment
dannyprikaz
left a comment
There was a problem hiding this comment.
Hey, James. Sorry for the late review on this. Maybe we should discuss in the meeting tonight, but I think that my comments should provide the right approach to unit testing models without creating a MongoMemoryServer
2 tasks
dannyprikaz
requested changes
Jul 15, 2025
jng34
commented
Jul 15, 2025
Member
Author
jng34
left a comment
jng34
left a comment
There was a problem hiding this comment.
Implemented the requested changes.
Member
|
@dannyprikaz Can you please review this PR when you have a moment? Once reviewed / merged, we can then unblock work on #1979 |
Member
|
Hi @dannyprikaz! Just checking in again - Can you please review this PR when you have a moment? Once reviewed / merged, we can then unblock work on #1979 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1951
What changes did you make and why did you make them ?
UsermodelScreenshot of passed tests