Bug Fix to show both Admins and Users in Project Members search#1977
Merged
jng34 merged 3 commits intohackforla:developmentfrom Jul 15, 2025
Merged
Bug Fix to show both Admins and Users in Project Members search#1977jng34 merged 3 commits intohackforla:developmentfrom
jng34 merged 3 commits intohackforla:developmentfrom
Conversation
Member
|
Thanks so much for putting together this PR so quickly, @jng34!! |
Member
|
@trillium Can you please take a look at this PR when you have a second? Once this is merged, we can rebuild Dev (and potentially Prod following testing). |
Member
|
@JackHaeg Looking at it now |
trillium
approved these changes
Jul 15, 2025
Member
trillium
left a comment
There was a problem hiding this comment.
Thanks for these changes James
There's a few other things that I'd like changed about how this query works, but I see that those problems weren't introduced via this PR so we'll address them in a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1976
What changes did you make and why did you make them ?
adminsandusersunder theProject Memberstab inUserPermissionSearchUserPermissionSearchin the directorysrc/pages, which is a duplicate of currently usedUserPermissionSearchin the directorysrc/components/user-adminto avoid confusionUsermodel to return correct type (array ofProjectIds) inmanagedProjectsfieldProjectmodel with the require validation for thenamefieldusers.router.testafter changes in theuser.controllerScreenshots of Proposed Changes Of The Website
Visuals before changes are applied
Visuals after changes are applied