refactor(admin-dashboard): replace JSX with MUI components#2045
refactor(admin-dashboard): replace JSX with MUI components#2045eunicode merged 1 commit intohackforla:developmentfrom
Conversation
d4863ce to
4cdf324
Compare
geolunalg
left a comment
There was a problem hiding this comment.
This looks good to me.
Minor nitpick — I would try to avoid cosmetic changes to the code so that only the necessary changes are visible in the PR. But like I said before, it looks good.
| }, | ||
| }, | ||
| signal | ||
| signal, |
There was a problem hiding this comment.
i assume most people are using vscode ... would implement a .prettierconfig to remove these kind of unwanted or sudden addition of commas an spaces in pull requests.
would help those who are reviewing the pull request, to review faster with less strain
There was a problem hiding this comment.
@akibrhast I think there is already an implementation of some sort of linting. I would also be hesitant to assume anyone is using a particular IDE. I think this can be discussed during our team meeting.
4cdf324 to
dbdc000
Compare
Fixes #1671
What changes did you make and why did you make them?
Refactored the Stats page (
/admin) to replace JSX elements (e.g.<div>,<p>) with MUI layout and display components (<Box>,<Typography>, etc.) for improved code and design consistency and use of MUI’s built-in features.Screenshots
No visual regressions were observed after the migration. The screenshots confirm that layout and appearance remain consistent.
Before (JSX elements)
After (MUI components)
Discussion
Are there general guidelines on when to use Tailwind utility classes versus MUI’s
sxprop or styled API?