Skip to content

SPIKE: Magic link#287

Merged
alex-anakin merged 10 commits intohackforla:developmentfrom
nickbeaird:magic_link
Sep 9, 2020
Merged

SPIKE: Magic link#287
alex-anakin merged 10 commits intohackforla:developmentfrom
nickbeaird:magic_link

Conversation

@nickbeaird
Copy link
Contributor

This Spike is to do some exploratory research into adding a Magic Link login functionality to the application.

High Level:

  1. User can sign up for the application at /api/auth/signup.
    -> There is validation and cleaning of the payload
    -> There is verification of email and basic data
    -> An email is sent to the user's email for verify the email.
    -> There are tests
  2. Admin users can log into the application. Non-admin users cannot.
    -> same as above
  3. We have a test email account. Permissions can be provided upon request.
  4. Refactor the tests to help make working easier.
  5. Move logic from routes to middleware and controllers
  6. Improve the import module system for the DB.

@nickbeaird nickbeaird linked an issue Sep 4, 2020 that may be closed by this pull request
@alex-anakin alex-anakin self-requested a review September 9, 2020 19:58
Copy link
Member

@alex-anakin alex-anakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I tested the branch locally, it works as described. Using nodemailer is exactly what we need to continue with Amazon SES.

@alex-anakin alex-anakin merged commit d1f3e15 into hackforla:development Sep 9, 2020
@nickbeaird nickbeaird deleted the magic_link branch September 13, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of Firebase

2 participants