Merged
Conversation
Closed
alex-anakin
approved these changes
Sep 9, 2020
Member
alex-anakin
left a comment
There was a problem hiding this comment.
Great work! I tested the branch locally, it works as described. Using nodemailer is exactly what we need to continue with Amazon SES.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Spike is to do some exploratory research into adding a Magic Link login functionality to the application.
High Level:
-> There is validation and cleaning of the payload
-> There is verification of email and basic data
-> An email is sent to the user's email for verify the email.
-> There are tests
-> same as above