Skip to content

Magic link 2#290

Merged
alex-anakin merged 28 commits intohackforla:developmentfrom
nickbeaird:magic_link_2
Oct 14, 2020
Merged

Magic link 2#290
alex-anakin merged 28 commits intohackforla:developmentfrom
nickbeaird:magic_link_2

Conversation

@nickbeaird
Copy link
Contributor

@nickbeaird nickbeaird commented Sep 11, 2020

STEPS TO VERIFY:

  1. Pull my repo.
  2. docker-compose build & docker-compose up
  3. Log into the localhost:3000 page for the main app
  4. Select the login button. Provide your email.
  5. Log into your email and use the link provided. The link should direct you to the login page.
  6. If you are not redirected to the login admin screen, then just refresh or login to the main page and press login again.

TODOs:

  • Alex to determine if the approach is valid.
  • Determine if we need to add a logout button now.
  • Possibly make the user experience better with a redirect.
  • Review the Tinyurl redirection for localhost
  • Whatever else you think.

@nickbeaird nickbeaird linked an issue Sep 11, 2020 that may be closed by this pull request
Copy link
Member

@alex-anakin alex-anakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I tried to log in under my own email. Firstly I got User does not exist. Then I made a small fix to the mongoose find command and got Invalid permissions. And here I'm confused because Mongoose returns [Object object] instead of actual user value. I used util.inspect so it is not an output issue.
  2. Login for non-existing user email displays "You don't have the correct access level" but should "Please enter the correct email address".

@nickbeaird
Copy link
Contributor Author

I updated the branch to work with the most recent conflicts.

  1. Pull my repo.
  2. docker-compose build & docker-compose up
  3. Log into the localhost:5000 page for the main app
  4. Select the login button. Provide your email.
  5. Log into your email and use the link provided. The link should direct you to the login page.
  6. If you are not redirected to the login admin screen, then just refresh or login to the main page and press login again.

TODOs:

  • Alex to determine if the approach is valid.
  • Determine if we need to add a logout button now.
  • Possibly make the user experience better with a redirect.
  • Review the Tinyurl redirection for localhost
  • Whatever else you think.

@alex-anakin alex-anakin mentioned this pull request Oct 13, 2020
@alex-anakin alex-anakin merged commit 99bdd6b into hackforla:development Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of Firebase

2 participants