Merged
Conversation
This reverts commit 8c5e874.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Update docker containers to be configurable for a CICD pipeline. The container setup with docker-compose works for local development purposes, but is not the most amenable for a CICD pipeline. The changes in this PR setup a multi-stage docker build to make for smaller images to be used in a pipeline, and also adds in docker start commands for each container to be used in isolation.
Acceptance:
[ ] The development containers work for a local development environment.
[ ] The containers can be run in isolation.
-> cd client
-> docker build -t CONTAINER_TAG --target client-production -f Dockerfile.client .
-> docker run --rm -it --name CONTAINER_NAME -p DESIRED_PORT:3000 CONTAINER_TAG