#322 implement create account page#402
Conversation
There was a problem hiding this comment.
Hey @ChrxsCrxss ,
Please, pull changes from development branch and resolve conflicts by:
- applying changes from development branch for
components/common/button/button.js - applying your changes + changes from development branch for
routes/index.js
Because tasks #386 and #322 have pretty similar functionality. It will be great to reuse code, utils, and service from merged PR #401.
Please, reuse:
utils/validation.jsto validate emailservices/user.service.jsto fetch data from API- existing components
<Title /> , <Button />, <Input />, <ErrorMessage />
Also, please rename the component name on CreateAccount, and path on /create-account. Because in MVP (v0.4) Requirements this page name's Create Account.
Please, let me know if you have any questions. And after applying these changes I'll provide a full code review.
|
Hey @OlgaBilogurova , I have completed everything above. However, there is an issue. When I use services/user.service.js to fetch data from API, I get a 401 error response even though the custom request header is included in the request. I checked the network request headers, and it shows x-customrequired-header as undefined. This is the case for fetches from the login page and createAccount page. |
|
@ChrxsCrxss , x-customrequired-header exists in VRMS/client-mvp-04/src/services/user.service.js Lines 1 to 4 in 1313f08 Please, update your .env variables and make sure that you have file src/setupProxy.js.Everything works for me. Please, push your changes I'll take a look at the code. |
|
@ChrxsCrxss , I'm able to fetch data from API for I just removed a line: https://drive.google.com/file/d/1O2Jk8UhHUdeyQJr7VCL61IwvTRv0UWZf/view?usp=sharing Please, double-check .env (for backend, client, client-mvp-04) and reinstall npm modules (for root, backend, client, client-mvp-04). If it still doesn't work, let's set up a meeting on Monday. |
OlgaBilogurova
left a comment
There was a problem hiding this comment.
@ChrxsCrxss , please, resolve my comments or response if you have another opinion.
Also, it would be great to cover CreateAccountContainer functionality with tests. You can create a separate task for this.
Please, use prettier locally during development. It helps to automate the cleanup, spacing of code, typos, empty line at the end of the file, and all code formatting.
client-mvp-04/src/components/createAccount/createAccountContainer.js
Outdated
Show resolved
Hide resolved
client-mvp-04/src/components/createAccount/createAccountView.test.js
Outdated
Show resolved
Hide resolved
client-mvp-04/src/components/createAccount/createAccountView.test.js
Outdated
Show resolved
Hide resolved
client-mvp-04/src/components/createAccount/createAccountContainer.js
Outdated
Show resolved
Hide resolved
client-mvp-04/src/components/createAccount/createAccountContainer.js
Outdated
Show resolved
Hide resolved
client-mvp-04/src/components/createAccount/createAccountContainer.js
Outdated
Show resolved
Hide resolved
client-mvp-04/src/components/createAccount/createAccountView.js
Outdated
Show resolved
Hide resolved
client-mvp-04/src/components/createAccount/createAccountView.js
Outdated
Show resolved
Hide resolved
|
@alex-anakin merge, please. |
Fixes #322.