Skip to content

Install MkDocs Documentation 3635#2

Merged
JessicaLucindaCheng merged 2 commits intohackforla:mainfrom
t-will-gillis:install-mkdocs-documents-3635
Mar 19, 2023
Merged

Install MkDocs Documentation 3635#2
JessicaLucindaCheng merged 2 commits intohackforla:mainfrom
t-will-gillis:install-mkdocs-documents-3635

Conversation

@t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Mar 13, 2023 •
edited by JessicaLucindaCheng
Loading

Fixes hackforla/website#3635

What changes did you make and why did you make them ?

  • Note that MkDocs is already installed and live
  • From discussion with Bonnie in the Sunday meeting, 12 March 23:
    • Added description/ documentation of which files have been installed so far
    • Added list of possible extensions/ plugins/ other options that we may want to consider. These are basic decisions such as adding a format color scheme, TOC, navbars, search capability, etc.

@JessicaLucindaCheng JessicaLucindaCheng mentioned this pull request Mar 14, 2023
Closed
2 tasks
JessicaLucindaCheng
JessicaLucindaCheng approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We looked at it during the Sun All Team meeting on 2023-03-19 and Bonnie approved it.

@JessicaLucindaCheng JessicaLucindaCheng merged commit 59cffa0 into hackforla:main Mar 19, 2023
JessicaLucindaCheng
JessicaLucindaCheng reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-will-gillis Good job on this documentation! I just noticed some broken links and an abbreviated word that I think should be spelled out for clarity. See my in-line comments.

Sorry for having you make the changes after I merged. The easiest way to make changes would probably be to update your main branch on your forked website-wiki and make a new branch out of it. Then make the changes on that branch and make a new pull request.

@JessicaLucindaCheng JessicaLucindaCheng mentioned this pull request Mar 19, 2023
Closed
6 tasks
@t-will-gillis t-will-gillis deleted the install-mkdocs-documents-3635 branch March 20, 2023 01:13
This was referenced Mar 20, 2023
Merged
Closed
@t-will-gillis

This comment was marked as outdated.

Sign in to view
@t-will-gillis t-will-gillis mentioned this pull request Mar 20, 2023
Merged
@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JessicaLucindaCheng JessicaLucindaCheng JessicaLucindaCheng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating Wiki: Install MkDocs

2 participants

@t-will-gillis @JessicaLucindaCheng