-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: MediumFeature: Design systemrole: front endTasks for front end developersTasks for front end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hoursstatus: UpdatedNo blockers and update is ready for reviewNo blockers and update is ready for review
Milestone
Description
Overview
As developers, we use reusable SCSS classes for styling Hack for LA webpages. For this issue, we will add the paragraph classes 1-3 defined in the Design System to our codebase.
Note: We will not be writing classes for paragraph classes 4-5 because the font size is illegible and should not be used on the website.
Action Items
- Locate the Paragraphs section under Typography in the Design System in Figma to see how the paragraph classes are defined.
- Look at the following SCSS files to see how title classes were implemented; paragraph classes should be implemented similarly.
- Based on how each paragraph class is defined in Figma, add SCSS paragraph classes 1-3 to _sass/elements/_typography.scss
- You may also need to define some variables in _sass/variables/_typography.scss
- Update paragraph definitions in Figma (if needed) to match code
Merge Team or Technical Leads
Once the pull request associated with this issue is approved and merged, please update the following:
- Edit issue Changing text size for Getting Started page #2656 by
- Checking off the dependency for this issue
- Moving issue Changing text size for Getting Started page #2656 into the New Issue Approval column and removing the Dependency label
- Edit issue Create new privacy policy page #2555 by
- Checking off the dependency for this issue
- Moving issue Create new privacy policy page #2555 into the In Progress column, removing the Dependency label, and assigning JessicaLucindaCheng to the issue. (Note: I, Jessica, was working on issue Create new privacy policy page #2555 prior to this one and needed the classes from this issue in order to continue work on issue Create new privacy policy page #2555. So, I had to stop work on issue Create new privacy policy page #2555 and complete this issue first. Once this issue is merged, I want to finish working on Create new privacy policy page #2555 since I have 65% of it done already.)
Resources/Instructions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: MediumFeature: Design systemrole: front endTasks for front end developersTasks for front end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hoursstatus: UpdatedNo blockers and update is ready for reviewNo blockers and update is ready for review
Type
Projects
Status
Done
