-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Refactor CSSPage is working fine - CSS needs changes to become consistent with other pagesPage is working fine - CSS needs changes to become consistent with other pagesrole: front endTasks for front end developersTasks for front end developerssize: missingstatus: UpdatedNo blockers and update is ready for reviewNo blockers and update is ready for review
Milestone
Description
Overview
Currently, the dropdown filters menus on the projects page and the toolkit page use different SCSS classes, which creates visual inconsistency for the user and also makes it hard for future developers to apply changes correctly. We need to create an SCSS file the will contain all the classes necessary to build our filter menus and store it in the elements folder for future use.
Action Items
- create a new SCSS file in the elements folder called _dropdown_filters.SCSS.
- Copy the entire contents of the _project-filter.scss file into the new _dropdown_filters.scss file.
- Import the new scss file you created into main.scss and delete the import for the original _project-filter.scss
- After you verify that the contents has been copied correctly, delete the original _project-filter.scss file in your local repo and test the site to make sure nothing is broken.
- Push your code to your feature branch.
- Demo your code with the merge team/tech leads. Which has not been made at this time. Check the bottom of this issue to see if an issue has been made yet. if not, leave a comment with this issue being done Design a fix the dropdown menu design for projects page #3277, if yes, then release dependency on the new issue that related this one.
Note to Merge Team/Tech Leads:
- If moving this file does not break any code on the site, have the assignee open a pull request and the changes can be merged. If something does break, create an issue to investigate why and correct it.
Resources/Instructions
Here is the _project-filter.scss file:
https://github.com/hackforla/website/blob/gh-pages/_sass/components/_project-filter.scss
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Refactor CSSPage is working fine - CSS needs changes to become consistent with other pagesPage is working fine - CSS needs changes to become consistent with other pagesrole: front endTasks for front end developersTasks for front end developerssize: missingstatus: UpdatedNo blockers and update is ready for reviewNo blockers and update is ready for review
Type
Projects
Status
Done