-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: MediumP-Feature: Wins Pagehttps://www.hackforla.org/wins/https://www.hackforla.org/wins/role: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hourstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Milestone
Description
Dependency
- Add latest version of Google Apps Scripts to GitHub #3641
- Create wiki page "Hfla Google Apps Script Development/Review Process" #4134
- Add new section "Testing Wins in a test repository" to the Wins Apps Script Development Wiki Page #5746
Overview
Currently the wins JSON feed contains no line breaks or spaces separating elements and so it is difficult to review Pull Requests for wins data updates. By formatting the JSON with each submission on a separate line and with use of spaces to indent, readability will be improved and JSON feeds could be compared more efficiently.
Action Items
- Request VIEW access to the Wins Form Admin Guide Doc, the Wins-form (Response) Sheet, and gh-requests Doc from the dev lead
- Read the Wins Form Admin Guide to understand the flow of wins data.
- This issue will require modification of the code within the
Wins-form (responses)sheet, but you will require a test environment that includes copies ofWins-form (Responses)andgh-requests. It will also be necessary to setup a test environment in your GitHub repository. Follow instructions in the comment in the Hfla Google Apps Script Development Guide1 and Testing WINS in a test repository2 - Once you have made copies of the required documents, let the dev lead know that access can be ended.
- In the Google Apps Script module Code.gs in the project WinsFormResponse, which is bound to
Wins-form (Responses)Sheet, update main() to format the _wins-data.json feed, either using options built into the JSON.stringify method, or a different method. Required features are:- Line Breaks separating array items (where each array item represents the data for a contributor)
- Line Break with spaces indenting properties within each array item
- Test the code by running main() in debug mode. A new pull request "Update wins-data.json via Google Apps Script" should be appear in your test repository. Examine the json data and if it looks good, merge into your repository test branch and examine the resulting Wins page.
- Add/commit
Code.jsand create a pull request as usual - In the pull request, provide links to the "Update wins-data.json via Google Apps Script" Pull Request and also the Wins page (both in your repository), for the convenience of reviewers.
- Contact a dev lead to discuss review/demonstration
Dev Lead
- Remove VIEW access to all protected documents
Resources/Instructions
- sample PR for updating wins data Update wins-data.json via Google Apps Script #4029
- (Create wiki page "Hfla Google Apps Script Development/Review Process" #4134 (comment))
- Wins data (json)
- Wins webpage
- wins.html
- Wins js
Footnotes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: MediumP-Feature: Wins Pagehttps://www.hackforla.org/wins/https://www.hackforla.org/wins/role: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hourstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Type
Projects
Status
Done