-
-
Notifications
You must be signed in to change notification settings - Fork 847
Open
Labels
Complexity: LargeDraftIssue is still in the process of being createdIssue is still in the process of being createdFeature: AccessibilityIssues that would broaden website accessibilityIssues that would broaden website accessibilityIssue Making: Level 2Make issue(s) from an ER or EpicMake issue(s) from an ER or Epicepicrole: front endTasks for front end developersTasks for front end developerssize: 2ptCan be done in 7-12 hoursCan be done in 7-12 hours
Milestone
Description
Dependencies
These issues have been created from the epic:
- Issue 1: Fix accessibility problems in the mobile navigation menu #4301
- Referring to the W3C sample code for navigation menu buttons (see Resources) update the HTML and JavaScript to do the following:
- make explicit the role and name of the hamburger icon/button using WAI-ARIA attributes, so that a screen reader is informed about the purpose of the button.
- add JavaScript to dynamically update the WAI-ARIA label "aria-expanded" so that a screen reader can announce whether the menu is expanded. Alternatively, create two separate
<button>elements, one for displaying the menu and the other for collapsing the menu, and mark each with an appropriate WAI-ARIA label. - assign the
taborderattribute to menu items so they are usable using keyboard navigation. - recommend if it is necessary to reformat the HTML in order to place the navigation button/menu within a
<hav>element, or ifrole="nav"should be added to another element.
- Referring to the W3C sample code for navigation menu buttons (see Resources) update the HTML and JavaScript to do the following:
- Issue 2: Enhance accessibility of the HfLA logo/Homepage link
- Refactor HTML so that the HfLA logo (? and the Donate link) are contained within a
<nav>element. - Improve "screen reader only" text for the logo or alternatively provide an explicit "Home" link.
- Refactor HTML so that the HfLA logo (? and the Donate link) are contained within a
- Issue 3: Update the wiki page https://github.com/hackforla/website/wiki/How-to-make-SVGs-and-other-images-WCAG-compliant with guidance specific to button icons.
Overview
This epic addresses several problems navigating the site using a screen reader.
Details for Issue 1
The following issues prevent screen reader users from being able to navigate the website for mobile screen sizes:
- On page load there is no accessible name or role given to the "hamburger" icon/button to indicate that activating the button will display the primary navigation menu. The screen reader announces the button as "button list item" and so many users will skip over the button and lack access to the navigation links.
- If the mobile navigation menu links are displayed (when the "hamburger" navigation menu button is activated), the menu item links are not keyboard accessible because they are not in the tab order. This is a result of the dynamic placement of the menu items.
Details for Issue 2
- In both mobile and desktop views, the HfLA logo is not enclosed in the
<nav>element and is not identified explicitly as representing the Home page. Currently it is identified to the screen reader user (usingsr-onlytext) as "Hack for LA internal link". Options include changing thesr-onlytext to "Hack for LA Homepage", adding aria-labels/roles to clarify, or adding an explicit Home link in addition to the clickable logo. - In both mobile and desktop views, the Donate link is not enclosed in the
<nav>element,
Resources
- Header Include
- main nav Include
- hamburger nav Include
- W3C - Menu Button Example
- ARIA - Navigation Role
Recommended Action Items
- Make a new issue
- Discuss with team
- Let a Team Lead know
Potential solutions [draft]
- Modify Fix accessibility problems in the mobile navigation menu #4301 to apply aria labels as described in https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-links/
- Research: which links should be enclosed by the
<nav>element. - Refactor code to create a
<nav>element that includes both mobile and wider screens, Requires updates to include files: header.html, main-nav.html and hamburger-nav.html and associated CSS OR Create a separate<nav>element for mobile view. - In either case,
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: LargeDraftIssue is still in the process of being createdIssue is still in the process of being createdFeature: AccessibilityIssues that would broaden website accessibilityIssues that would broaden website accessibilityIssue Making: Level 2Make issue(s) from an ER or EpicMake issue(s) from an ER or Epicepicrole: front endTasks for front end developersTasks for front end developerssize: 2ptCan be done in 7-12 hoursCan be done in 7-12 hours
Type
Projects
Status
Emergent Requests