-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Feature: Refactor HTMLP-Feature: Citizen Engagementhttps://www.hackforla.org/citizen-engagementhttps://www.hackforla.org/citizen-engagementgood first issueGood for newcomersGood for newcomersrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Milestone
Description
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.
Action Items
- In your local IDE, navigate to
_includes/program-area-pages-cards.html - Change the following from
<img class="sdg-image" src="{{ item.sdg-image-src }}" alt="{{ item.sdg-image-alt }}" />
to
<img class="sdg-image" src="{{ item.sdg-image-src }}" alt="{{ item.sdg-image-alt }}">
- Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)
Resources/Instructions
- For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/_includes/program-area-pages-cards.html
- Webpage: https://www.hackforla.org/citizen-engagement
- This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab, which is part of Rollout Plan: Refactor code with img HTML tags to end without a slash #4362
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Feature: Refactor HTMLP-Feature: Citizen Engagementhttps://www.hackforla.org/citizen-engagementhttps://www.hackforla.org/citizen-engagementgood first issueGood for newcomersGood for newcomersrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Type
Projects
Status
Done