-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: MediumFeature: Refactor JS / LiquidPage is working fine - JS / Liquid needs changes to become consistent with other pagesPage is working fine - JS / Liquid needs changes to become consistent with other pagesP-Feature: Project Info and PageA project's detail page (e.g. https://www.hackforla.org/projects/100-automations)A project's detail page (e.g. https://www.hackforla.org/projects/100-automations)P-Feature: Projects pagehttps://www.hackforla.org/projects/https://www.hackforla.org/projects/role: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hourstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Milestone
Description
Overview
We need to change secondRepoId to a more descriptive name so that it is clearer it will contain additional repository identification numbers (second, third, fourth, etc) for a project.
Details
- In future issue Display languages for projects that have 2 or more repos #5160, the code will be modified to support projects with 2 or more repositories.
Action Items
Developer
- In _projects/civic-tech-index.md 1, change
to
secondRepoId: '275296439'additional-repo-ids: '275296439' - In _layouts/project.html 2, change
to
secRepoId="{{ page.secondRepoId }}"additionalRepoIdNums="{{ page.additional-repo-ids }}" - In assets/js/current-projects.js 3, change the following:
- Change
to
'secondRepoId': {{project.secondRepoId | default: 0}},'additionalRepoIds': {{project.additional-repo-ids | default: 0}}, - Change
to
if(project.secondRepoId != 0){ const secMatchingProject = projectLanguagesArr.find(x=> x.id === project.secondRepoId); const langArr = [...matchingProject.languages, ...secMatchingProject.languages];if(project.additionalRepoIds != 0){ const additionalMatchingProject = projectLanguagesArr.find(x=> x.id === project.additionalRepoIds); const langArr = [...matchingProject.languages, ...additionalMatchingProject.languages];
- Change
- In assets/js/project.js 4, change
to
if (scriptTag.getAttribute("secRepoId")){ const secRepoId = scriptTag.getAttribute("secRepoId"); const firstLangs = project.languages; const secLangs = findProjectById(secRepoId).languages; let languagesArr = [...firstLangs, ...secLangs];if (scriptTag.getAttribute("additionalRepoIdNums")){ const additionalRepoIdNums = scriptTag.getAttribute("additionalRepoIdNums"); const firstLangs = project.languages; const additionalLangs = findProjectById(additionalRepoIdNums).languages; let languagesArr = [...firstLangs, ...additionalLangs]; - Using Docker, on the following web pages, check everything remains the same as on the live website:
- Projects page: https://www.hackforla.org/projects/, including checking the functionality of the filters and the contents of the Civic Tech Index card
- Civic Tech Index page: https://www.hackforla.org/projects/civic-tech-index, including checking the Languages field
Merge Team
- Once the pull request associated with this issue is merged, go to Display languages for projects that have 2 or more repos #5160 and check if all the issues listed under the Dependencies section are closed. If the dependencies are all closed, move Display languages for projects that have 2 or more repos #5160 into the New Issue Approval column, remove the "Dependency" label on it and add a "ready for prioritization" label to it.
Resources/Instructions
Footnotes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: MediumFeature: Refactor JS / LiquidPage is working fine - JS / Liquid needs changes to become consistent with other pagesPage is working fine - JS / Liquid needs changes to become consistent with other pagesP-Feature: Project Info and PageA project's detail page (e.g. https://www.hackforla.org/projects/100-automations)A project's detail page (e.g. https://www.hackforla.org/projects/100-automations)P-Feature: Projects pagehttps://www.hackforla.org/projects/https://www.hackforla.org/projects/role: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hourstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Type
Projects
Status
Done
Status
Done