HfLA: Dev Lead Team (Merge Team) Agenda

[roslynwythe]

Overview

This issue tracks the agenda for the monthly Website Dev Lead/Merge Team meeting

Template

## [DATE IN YYYY-MM-DD FORMAT] Meeting Agenda

### Recurring items: 
- [ ] Check to see how merge team members are doing
- [ ] Suggestions for improvements to issue/PR templates, PR instructions?
    
### FYIs (nothing needs to be done, just keeping each other informed)

### New Items 
add issue numbers to be discussed and any notes that will be helpful


### Notes from meeting

### Tasks

### Items for next week's agenda

Prior and upcoming meetings

• Oct 3, 2023

[github-actions]

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

• Wiki: How to create issues
• Wiki: How to read and interpret labels

[roslynwythe]

Oct 3, 2023 Meeting Agenda

Recurring items:

• Check to see how merge team members are doing
• Request for volunteers to lead meetings Monthly Signup for Merge Team/Dev Lead Team Task List Spreadsheet
• Reminder and thanks for monitoring #hfla-site and providing prompt support for members
• Please try to review extra PRs during planning week
• Suggestions for improvements to issue/PR templates, instructions, good first issues..
• meeting schedule:
  • Should we hold meeting on Halloween (Tues Oct 31st)?
  • Meeting on Sunday 11/26th will be cancelled

FYIs (nothing needs to be done, just keeping each other informed)

CodeQL

• codeql-implementation #4886 implemented "security and code quality" query set

• weekly scan on Fridays, scan on push, open/commit PRs

• alerts appear in the Security tab code scanning
  - tracking alert/issues see codeql scan alert 24
  - tracking analysis issue: recommend dismissal or code fix
  - dismissal process, documentation
  - if recommendation is to fix code, who will write the issue with the exact code fix?

  • PRs: code annotation DO NOT REVIEW: added a new line to generate a CodeQL alert #5204
  • alerts of severity “High” or higher cause a PR check to fail
  • pr instructions regarding alerts: Update PR template with instructions regarding CodeQL annotations #5196
  • problem with dev dismissing alert - see img tag refactor #5256 #5280
    • solution to this problem?
      • GitHub App can subscribe to CodeQL scan events and create an issue for review of all dismissed alerts.

• spell checking

  • first implement local spell checking (VSCode/npm) then repo checking (MegaLinter)
  • shared config file: cspell.json
  • current issues: auditing each page, updating cspell.json with "words", "ignore", and "ignorePath" arrays
  • Add Code Spell Checker VS Code extension installation instructions #4101 and add instructions for workstation spell checking using npm package #5652
  • VS Code Spell Checker Extension: Meeting Messaging #4470
  • Update PR template with instructions regarding spell check messages #5202
  • VS Code Spell Checker Extension: GHA Messaging #4469
    • proposal to develop GHA to add comment with checkbox upon issue assignment
    • proposal to develop GHA to add comment with checkbox in newly created PRs
    • proposal to develop GHA to add comments with checkbox to prework checklists
  • repo-level: use MegaLinter which includes cspell, ESLint, HTML Hint, others
  • Not sure if we will block merge on spell check errors

New Items

add issue numbers to be discussed and any notes that will be helpful

Notes from meeting

Tasks

Items for next week's agenda