Skip to content

Resolve CodeQL alert 5 and 7 "Potentially unsafe external link" #6226

@roslynwythe

Description

@roslynwythe

Dependency

  • _layouts/guides.html is in production (specified in _config.yml)

Note: when the above dependency is satisfied, before prioritizing this issue we must reopen the CodeQL alert on this page: https://github.com/hackforla/website/security/code-scanning/5 and https://github.com/hackforla/website/security/code-scanning/7

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to resolve the "Potentially unsafe external link" alerts which appears in the CodeQL alert 5 and alert 7 by adding the attribute rel="noopener noreferrer"

Action Items

            <a href="{{ item.links.github }}" target="_blank" title="GitHub Profile" class="fa fa-github fa-xl" style="margin-right: 13px; 
            text-decoration: none;"></a>

with

            <a href="{{ item.links.github }}" target="_blank" title="GitHub Profile" class="fa fa-github fa-xl" style="margin-right: 13px; 
            text-decoration: none;" rel="noopener noreferrer"></a>
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Merge Team

Resources/Instructions

  1. GitHub CodeQL documentation
  2. Sample webpage using this template: https://www.hackforla.org/guide-pages/2FA
  3. This issue is part of Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129

Metadata

Metadata

Assignees

No one assigned

    Labels

    Complexity: SmallTake this type of issues after the successful merge of your second good first issueDependencyAn issue is blocking the completion or starting of another issueFeature: Code Alertsmanual dependency releaserole: front endTasks for front end developerssize: 0.5ptCan be done in 3 hours or less

    Type

    No type

    Projects

    Status

    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions