-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueDependencyAn issue is blocking the completion or starting of another issueAn issue is blocking the completion or starting of another issueFeature: Code Alertsmanual dependency releaserole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or less
Milestone
Description
Dependency
-
pages/guides.htmlis published
Note: when the above dependency is satisfied, before prioritizing this issue we must reopen the CodeQL alert on this page: https://github.com/hackforla/website/security/code-scanning/22 and https://github.com/hackforla/website/security/code-scanning/24
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We need to resolve the "Potentially unsafe external link" alerts which appears in the CodeQL alert 22 and alert 24 by adding the attribute rel="noopener noreferrer"
Action Items
- The following items are required for GitHub to establish tracking between this issue and the alerts. No action is required. You may simply check the checkboxes. If you do follow the link to learn more about CodeQL alerts, DO NOT DISMISS THE ALERT.
- Open the file
pages/guides.htmlin your IDE - Replace BOTH instances of
<a href="{{ item.links.linked-in }}" target="_blank" title="Linkedin Profile" class="fa fa-linkedin fa-xl" style="margin-right: 13px;
text-decoration: none;"></a>
with
<a href="{{ item.links.linked-in }}" target="_blank" title="Linkedin Profile" class="fa fa-linkedin fa-xl" style="margin-right: 13px;
text-decoration: none;" rel="noopener noreferrer"></a>
- Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)
Merge Team
- When this issue is completed, check off the issue in Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129
Resources/Instructions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueDependencyAn issue is blocking the completion or starting of another issueAn issue is blocking the completion or starting of another issueFeature: Code Alertsmanual dependency releaserole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or less
Type
Projects
Status
Done