-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: MediumFeature: Code Alertsrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hours
Milestone
Description
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We need to analyze the query "Use of returnless function" which appears in the CodeQL alert 57 then either recommend dismissal of the alert or update code to resolve the alert.
Action Items
- DO NOT DISMISS ANY ALERTS. Dismissal of alerts should be done by dev leads only after review of the recommendation
- Browse to the links in the following two Action Item and read the contents. Click "See More" to view Recommendations, Examples and References.
- https://github.com/hackforla/website/security/code-scanning/57
- In a comment in this issue, add your analysis and recommendations. For each alert, the recommendation can be one of the following:
dismiss as test,dismiss as false positive,dismiss as won't fix, orupdate code. - If the recommendation is to update code:
- create an issue branch and proceed with the code update
- Use docker to test locally, ensuring that there are no changes to any affected webpage(s)
- proceed with pull request in the usual manner
- If the recommendation is to dismiss, describe your reason for dismissal in the comment, then move the issue to
Questions/In Reviewand apply the labelready for dev lead.
For merge team/dev lead
- If recommendation to dismiss is approved, dismiss the alert with a comment, then close the issue as completed.
- When this issue is closed please check it off (under "Issues") in Create issues to resolve all open CodeQL alerts #5159. If all child issues are closed, close Create issues to resolve all open CodeQL alerts #5159 as completed.
Resources/Instructions
- GitHub CodeQL documentation
- This issue is part of Create Issues for Analysis of CodeQL alerts #5060
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: MediumFeature: Code Alertsrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 1ptCan be done in 4-6 hoursCan be done in 4-6 hours
Type
Projects
Status
QA