Skip to content

Resolve "Potentially unsafe external link" in _includes/current-guides.html #6484

@roslynwythe

Description

@roslynwythe

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to fix a potentially unsafe external link by adding the attribute rel="noopener noreferrer". The problem and the solution is similar the those detailed in https://github.com/hackforla/website/security/code-scanning/3, however the instance addressed by this issue did not result in a CodeQL alert.

Action Items

  • Open the file _includes/current-guides.html in your IDE
  • Replace
                        <a href="{{item.resource-url}}" class="toolkit-flex-item-status" target="_blank">

with

                        <a href="{{item.resource-url}}" class="toolkit-flex-item-status" target="_blank" rel="noopener noreferrer">
  • Using Docker, check the url /toolkit and check that the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below). Refer to the Resources/Instructions section for a screenshot of the hyperlink modified in this issue (highlighted in yellow). Confirm that link still works.

Merge Team

Resources/Instructions

hyperlink modified in this issue

image

  1. GitHub CodeQL documentation
  2. Webpage: https://www.hackforla.org/toolkit
  3. This issue is part of Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129

Metadata

Metadata

Assignees

Type

No type

Projects

Status

QA

Relationships

None yet

Development

No branches or pull requests

Issue actions