-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Closed
Copy link
Labels
Feature: Code Alertsgood first issueGood for newcomersGood for newcomersrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Milestone
Description
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We need to fix a potentially unsafe external link by adding the attribute rel="noopener noreferrer". The problem and the solution is similar the those detailed in https://github.com/hackforla/website/security/code-scanning/3, however the instance addressed by this issue did not result in a CodeQL alert.
Action Items
- Open the file
_includes/current-guides.htmlin your IDE - Replace
<a href="{{item.resource-url}}" class="toolkit-flex-item-status" target="_blank">
with
<a href="{{item.resource-url}}" class="toolkit-flex-item-status" target="_blank" rel="noopener noreferrer">
- Using Docker, check the url
/toolkitand check that the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below). Refer to the Resources/Instructions section for a screenshot of the hyperlink modified in this issue (highlighted in yellow). Confirm that link still works.
Merge Team
- When this issue is completed, check off the issue in Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129
Resources/Instructions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Feature: Code Alertsgood first issueGood for newcomersGood for newcomersrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Type
Projects
Status
QA
