-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Onboarding/Contributing.mdrole: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or less
Milestone
Description
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started Page.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We need to fix the following line of code to correctly capitalize "Slack" when it's used to refer to the app or the company in our code and content.
Line 582 in 612389d
- If you still do not see your changes after trying these steps, please feel free to reach out to the team in the [#hfla-site](https://hackforla.slack.com/archives/C4UM52W93) slack channel, or bring up your issue in a dev meeting.
Action Items
- Open the file
CONTRIBUTING.MDin your code editor - On Line 582 replace every
slackwithSlackwhen it's used to refer to the app and the company, do not make changes within URLs. Do not change any other lines in the file. - Changes to CONTRIBUTING.md should not be tested locally, rather they need to be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL. Also store the test URL for use in a later step:
https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md
(for example: https://github.com/bonniewolfe/website/blob/issue-branch-1234/CONTRIBUTING.md)
- Create a pull request with your changes. In the Pull Request, after the "Why did you make the changes" section, add this line to help reviewers, replacing the text in brackets (and the brackets) with the test URL from the previous Action Item.
For Reviewers: Do not review changes locally, rather, review changes at [REPLACE WITH TEST URL]
For Merge Team
- Release the dependency for this issue in Epic: Create Issues to Correctly Capitalize "Slack" in CONTRIBUTING.MD #6844. If all the dependencies have been completed, close that issue.
Resources/Instructions
- Getting started with writing and formatting on GitHub
- For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.MD?plain=1
This issue is part of Issue Making Issue #6844 and ER #6163.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Onboarding/Contributing.mdrole: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or less
Type
Projects
Status
Done