Wins works

[jbubar]

This is a collaborative PR between me and @akibrhast. He redesigned the structure of the wins page, and I put the finishing touches. @akibrhast put most of the work in for this pr.
I also added some code for restructuring the card so that the quotes show up in the right place

Fixes #1066
closes #1060

[jbubar]

desktop view

Mobile

overlay

[jbubar]

@martham0 Thanks for pointing that out. not sure how that slipped through the cracks. Next time I will be a lot more careful with resolving merge conflicts.
Does that sort it out?

[akibrhast]

Everything works as expected! Ready to merge once docker-compose.yml has been removed from the commit. @jbubar

[ItsLaszlo]

@martham0 Thanks for pointing that out. not sure how that slipped through the cracks. Next time I will be a lot more careful with resolving merge conflicts.
Does that sort it out?

Yup! I am able to run it.

[ItsLaszlo]

Everything seems to be working as expected! Only a quick note about a possible duplicate file mentioned above.

This might be nitpicky and maybe a cause for another issue to be created but when using the dropdown filters the cursor change isn't accurate. It changes to cursor: pointer when hovering over anywhere in the dropdown except for the checkbox. On the checkbox, it turns back into a normal cursor. This can be a bit confusing for the user and implies they can select the category by clicking it rather than clicking the checkbox which isn't the case.

[akibrhast]

Everything seems to be working as expected! Only a quick note about a possible duplicate file mentioned above.

This might be nitpicky and maybe a cause for another issue to be created but when using the dropdown filters the cursor change isn't accurate. It changes to cursor: pointer when hovering over anywhere in the dropdown except for the checkbox. On the checkbox, it turns back into a normal cursor. This can be a bit confusing for the user and implies they can select the category by clicking it rather than clicking the checkbox which isn't the case.

@martham0 Could you please open a new ticket with what you mentioned here? The same behavior can also be seen on the projects page as well. I am guessing we could make a ticket that calls for an action to fix it in both places?

[ItsLaszlo]

Everything seems to be working as expected! Only a quick note about a possible duplicate file mentioned above.
This might be nitpicky and maybe a cause for another issue to be created but when using the dropdown filters the cursor change isn't accurate. It changes to cursor: pointer when hovering over anywhere in the dropdown except for the checkbox. On the checkbox, it turns back into a normal cursor. This can be a bit confusing for the user and implies they can select the category by clicking it rather than clicking the checkbox which isn't the case.

@martham0 Could you please open a new ticket with what you mentioned here? The same behavior can also be seen on the projects page as well. I am guessing we could make a ticket that calls for an action to fix it in both places?

Will do! The issue can be found here: #1155

[akibrhast]

Hey @jbubar If I am not mistaken.. This pull request will also close
#1060 .
Could you confirm that, and if it is case , link it to this pull request

[jbubar]

Hey @jbubar If I am not mistaken.. This pull request will also close
#1060 .
Could you confirm that, and if it is case , link it to this pull request

@akibrhast. Right! I did. and I will create a new issue for when it is done #1163

Thanks. and thanks for your patience. been moving around a bunch this week. Next week I will have some more free time. Best of luck this sunday :))

[akibrhast]

Everything looks good and ready for merge. @martham0 Thanks for creating that issue, and feel free to go ahead and merge it once you have had the time to review it yourself :D!

[drubgrubby]

This is really great work! I love the new way of structuring complex pages.

The only thing I notice is a small thing on the layout of the cards: The linkedIn and GitHub images seem to be much closer together than they are on the current site.

Current site:

This PR:

This may be correct, but I didn't see any discussion of it so I'd like to have @daniellex0 sign off on it before we merge.

[jbubar]

The only thing I notice is a small thing on the layout of the cards: The linkedIn and GitHub images seem to be much closer together than they are on the current site.

good catch!

[drubgrubby]

@jbubar - Thanks for making the change to the space between the linkedin and github images. It looks good to me and ready to merge.

@martham0 - It seems like this is ready to merge. If you agree, then please go ahead and squash and merge.

[ItsLaszlo]

Everything looks good to me. I'll squash and merge!