Skip to content

Rename about us page to about#1140

Merged
drubgrubby merged 2 commits intohackforla:gh-pagesfrom
kevinreber:864-rename-about-us-page-to-about
Mar 1, 2021
Merged

Rename about us page to about#1140
drubgrubby merged 2 commits intohackforla:gh-pagesfrom
kevinreber:864-rename-about-us-page-to-about

Conversation

@kevinreber
Copy link
Contributor

fixes #864

  • Renamed about-us page and it's assets to about
  • Renamed _about.scss as _home.scss
  • Imported _home.scss into main.scss
  • Renamed _about-us.scss as _about.scss
  • Delete _about-us.scss and remove from main.scss

@akibrhast
Copy link
Member

@kevinreber Can you please explain what these changes in the image below in your pull request mean?

Img

image

These are the only files that should have been changed in this pull request right? Why are assets and image files within the commit?

  • Renamed about-us page and it's assets to about
  • Renamed _about.scss as _home.scss
  • Imported _home.scss into main.scss
  • Renamed _about-us.scss as _about.scss
  • Delete _about-us.scss and remove from main.scss

@kevinreber
Copy link
Contributor Author

@akibrhast

I assumed after renaming assets/js/about-us.js to assets/js/about.js we may want to rename the assets/images/about-us directory to assets/images/about to avoid any future confusion between the about page and the about section on the homepage

Screenshot

image

@akibrhast
Copy link
Member

@kevinreber owh owh! That's cool! Thanks! I was just asking , cause I didn't understand it. Thanks for your explanation.

Copy link
Member

@drubgrubby drubgrubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinreber - Really nice work! This seemed like it was going to be a simple change, but it turned out that there were a lot more moving pieces that I suspected. Looks to me like you caught them all. This looks ready to merge to me.

@drubgrubby drubgrubby merged commit 5b9d6d9 into hackforla:gh-pages Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename about-us page to about

3 participants