Skip to content

fixes the issue where if clicked the page would stop displaying info…#1147

Merged
akibrhast merged 4 commits intohackforla:gh-pagesfrom
thatguyish:fix-events-page-strange-behavior
Mar 3, 2021
Merged

fixes the issue where if clicked the page would stop displaying info…#1147
akibrhast merged 4 commits intohackforla:gh-pagesfrom
thatguyish:fix-events-page-strange-behavior

Conversation

@thatguyish
Copy link
Contributor

@thatguyish thatguyish commented Mar 1, 2021

Fixes #1106

…rmation (like meetup events, and team meetings)

…rmation (like meetup events, and team meetings)
Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cute little carrot animation on mobile seemed to have broke. Here is what it looks like on the live page.. I think you might need to add back in the this.classList.toggle("active") some how

live site

@akibrhast akibrhast requested a review from jbubar March 2, 2021 03:47
}
}
window.addEventListener('resize',fixDropDown)
function fixDropDown(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function fixDropdown()

Please rename your function to what it does and not what it fixes

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. just noticed something...
When you resize from desktop to mobile.. the accordions should start out closed

@thatguyish
Copy link
Contributor Author

@jbubar okay cool thank you 😁 will make hopefully final changes lol.

@thatguyish
Copy link
Contributor Author

@jbubar should be good lol sorry about that.

@akibrhast akibrhast merged commit d54d867 into hackforla:gh-pages Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange behavior on 'Events' page

3 participants