Fix buggy header navigation bar#1157
Conversation
A1. The navigation bar is still buggy, where it would default to open state in mobile viewScreen.Recording.2021-03-03.at.10.03.27.AM.movB1. After closing the header navigation, the hamburger navigation icon remains until it is 768px for width.B2. The header navigation bar disappears from 768 - 975px.Screen.Recording.2021-03-03.at.10.10.20.AM.mov |
|
@qiqicodes It seems to be working fine on my side. Were those videos run before or after cache clearing? |
|
@qiqicodes After our zoom screen sharing just now. I have been unable to replicate the issue on my end. I have tried replicating the issue in both chrome and edge whilst setting the height to 962px as your video has it. However I am still unable to replicate what your video shows. I have confirmed that @qiqicodes did clear her cache. @qiqicodes Could you please provide the chrome version that your test in the video ran on? @drubgrubby @jbubar - Would it be possible for you folks to pull this and try it out on your end. If you are able to replicate the problems as shown in the video. Could you please give details on how you managed to replicate it .. Since I am not able to.
|
|
@akibrhast I'm running the latest Chrome version. I have tried rendering the page again with docker. The navigation bar still drops down. |
|
@qiqicodes I also noticed this issue on my machine, but it rarely happens on my end. Tried recreating the issue it on Safari with @akibrhast and didn't have any problems. I'm working on macOS Catalina
|
kevinreber
left a comment
kevinreber
left a comment
There was a problem hiding this comment.
Looks good! Works on my machine
There was a problem hiding this comment.
@akibrhast this is great!
It fixed a few bugs with the nav!
and the code is simpler too.
4 participants
Fixes #1055