Skip to content

Alt text audit #1355

Merged
jbubar merged 25 commits intohackforla:gh-pagesfrom
qiqicodes:qiqi-1192-alt-text-audit
Apr 13, 2021
Merged

Alt text audit #1355
jbubar merged 25 commits intohackforla:gh-pagesfrom
qiqicodes:qiqi-1192-alt-text-audit

Conversation

@qiqicodes
Copy link
Member

@qiqicodes qiqicodes commented Apr 4, 2021

fixed #1192

Action Items

  • Confirm every image has an alt attribute
  • Add appropriate descriptions for images

Why is alt text important?

  • Alt texts take place of the image, when user choose to lower their data usage.
  • Screen readers read alt texts for users who may or may not have access to the images available.

Resources

Tips

  • For informational non-text content, as you review, try to imagine the image presented if the alt text can recreate the image.
  • For decorative image, keep alt="" (i.e. blue background is negligible).
  • For more details, refer to WCAG 2.0 guideline.

@qiqicodes qiqicodes requested review from akibrhast and jbubar April 4, 2021 21:01
Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty extensive pull request!
Great work.. just finished my first pass through.
I read all the changes, and they are all really well written and descriptive.
I will test out all the pages tomorrow.

@akibrhast akibrhast requested review from ItsLaszlo and removed request for akibrhast April 5, 2021 16:50
@akibrhast
Copy link
Member

@qiqicodes Could you please resolve the merge conflicts and apply the changes as requested by @martham0

@jbubar
Copy link
Member

jbubar commented Apr 13, 2021

@qiqicodes could you resolve the merge conflict again?

also, this happened when I pulled it so jekyll did not render the files
Screen Shot 2021-04-13 at 11 36 23 AM
not sure why.. I looked at the files and nothing seemed off. could you run it locally on your machine and see if you get any similar errors?

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ready to merge, I looked through all the projects, and pages... I hope.. This was a lot to review

@jbubar jbubar merged commit 8d16b82 into hackforla:gh-pages Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm every image has an alt attribute

4 participants