Toolkit scss consolidation#1368
Conversation
- Got rid of .outer-link class - Added a tag in the toolkit-flex-item.section-container
|
looks good to me |
|
@sena-ji Just confirming, is this connected to an issue? Sorry, I'm not quite sure what the context is! Is this a followup to the Tuesday CSS discussion? |
Nope! I was asked to create a pull request of the standardization we did during the developers meeting. |
|
Ah ok got it- this removes the link from the resource cards? Could you post a screenshot of how it looks with the changes please? I'll run it by the design team meeting tomorrow first if possible since it's a UX design-related change (Also there's a chance Bonnie might want to weigh in on this, I'll check) |
No, it does not. Should not. |
|
@akibrhast Ohh ok sorry just ran this myself now and pulled it up (as I should have in the beginning!)- so this should all just look the same, but with more standard CSS, got it. Ok looks good to me. Just to confirm, .not-clickable is removed because it wasn't being used anywhere, right? Btw (and this is not a critique at all because I did the same thing forever!), but in the future @sena-ji in PR's please list out the changes that you made with quick explanations if possible, thank you! :) (unless it's already all listed out in an attached issue) |
Got it Danielle! I will make sure to do that for future PRs. Thank you for the feedback :) |
4 participants
Updated Toolkits pages for standardization