Standardize events page 1125#1377
Merged
akibrhast merged 6 commits intohackforla:gh-pagesfrom Apr 10, 2021
Merged
Conversation
akibrhast
suggested changes
Apr 8, 2021
akibrhast
approved these changes
Apr 8, 2021
Member
akibrhast
left a comment
akibrhast
left a comment
There was a problem hiding this comment.
LGTM. Feel free to merge if everything is good on your end @daniellex0
daniellex0
requested changes
Apr 10, 2021
_sass/components/_events.scss
Outdated
| float: left; | ||
| transition: transform 0.25s ease-in; | ||
| color: #000000; | ||
| color: $color-black |
Member
There was a problem hiding this comment.
I think there is a ";" missing after the $color-black here :)
Member
|
Great, btw thanks for detailing all the changes you made above @erikaBell ! Looks good to go 👍 |
daniellex0
approved these changes
Apr 10, 2021
Member
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 1125
Fixes #1125
I also added variable
$color-gold: #F2C94D, to our _colors.scss fileAnd repaired all colors that weren't using our variables
#000000became$color-black#FFFFFFbecame$color-white#FA114Fbecame$color-redEvents Page: Banner full length & Icon + Pink Arrow have spacing