Adjust Wins page styling 1336#1386
Merged
jbubar merged 4 commits intohackforla:gh-pagesfrom Apr 13, 2021
Merged
Conversation
Member
Author
Member
|
@erikaBell Nice work! |
daniellex0
requested changes
Apr 11, 2021
Member
daniellex0
left a comment
There was a problem hiding this comment.
Looks good @erikaBell ! The only change I have is:
In mobile only: make the "Team(s)" and "Role(s)" sections the same font size- 15px - use rem units (currently one is 12px and one is 16px)
To make sure these are 15px (in rem) in mobile (instead of 16px) :) - sorry I know it probably would make more sense if I wrote 16px on there lol, but trying to make these less prominent and not push the content in the card too far down/close to its bottom edge
daniellex0
approved these changes
Apr 13, 2021
Member
daniellex0
left a comment
There was a problem hiding this comment.
Sorry about the delay, looks good! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1336
Additional style changes were put on "...see more" (appears during mobile view), as the changes from issue #1336 altered their placement.
Adjustments to Wins Page Styling, mobile view
Filter List Re-size, full screen view