Skip to content

Adjust Wins page styling 1336#1386

Merged
jbubar merged 4 commits intohackforla:gh-pagesfrom
erikaBell:wins-page-styling-1336
Apr 13, 2021
Merged

Adjust Wins page styling 1336#1386
jbubar merged 4 commits intohackforla:gh-pagesfrom
erikaBell:wins-page-styling-1336

Conversation

@erikaBell
Copy link
Member

@erikaBell erikaBell commented Apr 10, 2021

Fixes #1336

  • In mobile only: make the heading ('let's celebrate together!') 32px (instead of 38px) - use rem units
  • In mobile only: make the "Team(s)" and "Role(s)" sections the same font size- 15px - use rem units (currently one is 12px and one is 16px)
  • Try to also add a little margin between all of these lines (person's name, Teams, Roles) to give it some breathing room- maybe something like 3px?
  • Remove the margin-top from the volunteers' names on the wins cards
  • Change desktop .wins-page-contain>ul.filter-list width to 40% (instead of 46%) so that filters are less wide
  • Try to make only this header button ("Share your wins") use the properties of class ".btn-md-narrow" (smaller size) only in mobile - without affecting the mobile version of any other buttons on the site that use the same button classes (this might require adding the properties to mobile media query in .btn--wins)

Additional style changes were put on "...see more" (appears during mobile view), as the changes from issue #1336 altered their placement.

Adjustments to Wins Page Styling, mobile view

image

Filter List Re-size, full screen view Screen Shot 2021-04-09 at 8 25 12 PM

@erikaBell erikaBell requested a review from daniellex0 April 10, 2021 03:27
@erikaBell
Copy link
Member Author

I think this issue fixes issue #1376 as well? @jbubar

@jbubar
Copy link
Member

jbubar commented Apr 11, 2021

@erikaBell Nice work!
It would.. Ill go close that issue!
I dont have time to review until after sunday, but it looks great

Copy link
Member

@daniellex0 daniellex0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @erikaBell ! The only change I have is:

In mobile only: make the "Team(s)" and "Role(s)" sections the same font size- 15px - use rem units (currently one is 12px and one is 16px)

To make sure these are 15px (in rem) in mobile (instead of 16px) :) - sorry I know it probably would make more sense if I wrote 16px on there lol, but trying to make these less prominent and not push the content in the card too far down/close to its bottom edge

@erikaBell erikaBell requested a review from daniellex0 April 11, 2021 16:47
Copy link
Member

@daniellex0 daniellex0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay, looks good! 👍

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@jbubar jbubar merged commit d415613 into hackforla:gh-pages Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust styling of Wins page

3 participants