Skip to content

Add xml to site#1387

Merged
jbubar merged 4 commits intohackforla:gh-pagesfrom
akibrhast:223-add-xml-to-site
Apr 13, 2021
Merged

Add xml to site#1387
jbubar merged 4 commits intohackforla:gh-pagesfrom
akibrhast:223-add-xml-to-site

Conversation

@akibrhast
Copy link
Member

@akibrhast akibrhast commented Apr 10, 2021

Closes #223

The following PR makes use of the existing default jekyll plugin to generate a sitemap.xml .

Example of generated sitemap can be found here

The plugin

  • jekyll-sitemap

Screenshot of generated sitemap

Sitemap_Screenshot

image

@akibrhast akibrhast requested review from erikaBell and jbubar April 10, 2021 15:31
Copy link
Member

@erikaBell erikaBell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah.. This is really cool! But I do want to get @cnk 's approval before merging

@jbubar jbubar requested a review from cnk April 13, 2021 20:58
@cnk
Copy link
Member

cnk commented Apr 13, 2021

Excellent! @akibrhast showed that it works on GH sites so I say go for it!

@jbubar jbubar merged commit 9c1d90b into hackforla:gh-pages Apr 13, 2021
@akibrhast akibrhast deleted the 223-add-xml-to-site branch June 22, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add XML tree to site

4 participants