Removed deprecated Docker Toolbox info from document#1396
Merged
jbubar merged 1 commit intohackforla:gh-pagesfrom Apr 13, 2021
Merged
Removed deprecated Docker Toolbox info from document#1396jbubar merged 1 commit intohackforla:gh-pagesfrom
jbubar merged 1 commit intohackforla:gh-pagesfrom
Conversation
averdin2
approved these changes
Apr 12, 2021
Member
averdin2
left a comment
averdin2
left a comment
There was a problem hiding this comment.
@RobertaFricker Everything looks good to me. Great job!
Member
Author
|
Thanks and congratulations on your first pull request approval!
…On Mon, Apr 12, 2021 at 9:58 AM Alex Verdin ***@***.***> wrote:
***@***.**** approved this pull request.
@RobertaFricker <https://github.com/RobertaFricker> Everything looks good
to me. Great job!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1396 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATLQAEQHJOM65JI4VFYPSJ3TIMRCHANCNFSM42X6UH2Q>
.
|
Member
Author
|
Hi again, I don't see the pull request as being completed yet...?
…On Mon, Apr 12, 2021 at 12:05 PM Code Chick ***@***.***> wrote:
Thanks and congratulations on your first pull request approval!
On Mon, Apr 12, 2021 at 9:58 AM Alex Verdin ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> @RobertaFricker <https://github.com/RobertaFricker> Everything looks
> good to me. Great job!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1396 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ATLQAEQHJOM65JI4VFYPSJ3TIMRCHANCNFSM42X6UH2Q>
> .
>
|
jbubar
approved these changes
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1382
Due to Docker Toolbox being deprecated recently, the text regardiing it has been removed from CONTRIBUTING.md document.