Skip to content

Replace png with jpg image#1400

Merged
jbubar merged 3 commits intohackforla:gh-pagesfrom
RobertaFricker:replace-png-with-jpg-image
Apr 13, 2021
Merged

Replace png with jpg image#1400
jbubar merged 3 commits intohackforla:gh-pagesfrom
RobertaFricker:replace-png-with-jpg-image

Conversation

@RobertaFricker
Copy link
Member

Fixes #1341
Fixes #389

Deleted ballot-nav.png and added ballotnav.jpg for issue 1341.
Added comment to ballotnav page, Issue 389 advising them change was completed, pull request added, and provided screenshot below:

image

@RobertaFricker RobertaFricker requested a review from averdin2 April 13, 2021 00:28
Copy link
Member

@averdin2 averdin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobertaFricker You forgot to make changes in the ballot-nav.md file. You need to replace the image path with the correct image. I'll add a screenshot of the image path so you know where. Just change the underlined part to ballotnav.jpg. You can find the file you need to change in _projects/ballot-nav.md. After you make the changes, just commit and push, and it should update the pull request.

image

Copy link
Member

@averdin2 averdin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbubar jbubar merged commit 8615b36 into hackforla:gh-pages Apr 13, 2021
@ExperimentsInHonesty
Copy link
Member

@jbubar @RobertaFricker This is not working. Here is how it looks on the site now. Please revert and then figure out why
Screen Shot 2021-04-13 at 4 13 09 PM

@RobertaFricker
Copy link
Member Author

RobertaFricker commented Apr 14, 2021

It should be correct now per the following screenshot of the localhost:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project Card Update - BallotNav

4 participants