Skip to content

Create Design System page#2070

Merged
Aveline-art merged 13 commits intohackforla:gh-pagesfrom
arghmatey:design-system-webpage
Aug 28, 2021
Merged

Create Design System page#2070
Aveline-art merged 13 commits intohackforla:gh-pagesfrom
arghmatey:design-system-webpage

Conversation

@arghmatey
Copy link
Contributor

@arghmatey arghmatey commented Aug 7, 2021

Fixes #1927

What changes did you make and why did you make them ?

  • Created front end of design system page. Not all styling is complete. Design system starts on /design-system page, then when a component is chosen design-system layout is loaded. This is similar to guide-pages from /toolkit page, but the visual layout remains the same.
  • Created design-system collection to display on front end.

Action Items

  • Complete adding component information from Figma to md files - both for buttons and page cards. This is just copy/paste and will not take long.
  • Style page to match Figma file. This includes researching and implementing code block coloring, though this could be turned into a separate issue after MVP is complete.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

August 7, 2021 Progress
August 7, 2021 Progress

@arghmatey arghmatey changed the title Design system webpage Create Design system webpage Aug 7, 2021
@arghmatey arghmatey mentioned this pull request Aug 7, 2021
5 tasks
@arghmatey
Copy link
Contributor Author

arghmatey commented Aug 13, 2021

From your project repository, check out a new branch and test the changes.

git checkout -b arghmatey-design-system-webpage gh-pages
git pull https://github.com/arghmatey/website.git design-system-webpage

August 13, 2021 Progress
Screen Shot 2021-08-13 at 10 46 35 AM

@arghmatey arghmatey changed the title Create Design system webpage Create Design System page prototype Aug 17, 2021
@Aveline-art
Copy link
Member

@arghmatey Just want to note that if the site is still waiting on some components before it can go live, we can always set published to false and that should hide the site for now.

@arghmatey
Copy link
Contributor Author

@Aveline-art Good idea! I've set published to false.

@abuna1985 abuna1985 marked this pull request as ready for review August 22, 2021 17:24
@abuna1985 abuna1985 requested review from Aveline-art, abuna1985 and macho-catt and removed request for Aveline-art August 22, 2021 17:24
@arghmatey
Copy link
Contributor Author

Converted from draft to ready to review. Margins are off. They are still being finalized by design. Reached out and am waiting for update.

Discussed moving on with what we have and creating new smaller issues for things we are waiting for. Will update with new issue numbers as they are created.

@arghmatey arghmatey changed the title Create Design System page prototype Create Design System page Aug 25, 2021
@arghmatey
Copy link
Contributor Author

Updated with new margins, resolved conflicts, and added a rough mobile view.

@Aveline-art Aveline-art self-requested a review August 26, 2021 22:46
Aveline-art
Aveline-art previously approved these changes Aug 27, 2021
Copy link
Member

@Aveline-art Aveline-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a look at it all, and this is all very impressive work! Everything is so reusable and so easy to add to!

One thing to note: we have recently decided to name the files in the _includes directory according to the pages they are used in. The example directory should ideally be further nested in a design-system-page directory. After that, I will say this is ready to merge, unless someone else has other thoughts.

You have outdone yourself again @arghmatey ! I feel so honored to review and witness such great work. Thank you!

@arghmatey
Copy link
Contributor Author

@Aveline-art Thanks for your review and kind words. :) I've pushed a new commit to reflect our new naming convention.

Copy link
Member

@Aveline-art Aveline-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Feel free to make new issues for follow up tasks, or continue working on the issue.

From what I can see, issues can be made for:

  • solving the sticky-nav issue
  • adding the typography section

Also, it might be prudent to document the architecture of these pages in a new wiki, as well as steps to adding new pages/components.

@Aveline-art Aveline-art merged commit 8501dca into hackforla:gh-pages Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the design system pages

3 participants