refactored the lines for button styling in join-us page#2196
Merged
macho-catt merged 3 commits intohackforla:gh-pagesfrom Aug 31, 2021
Merged
refactored the lines for button styling in join-us page#2196macho-catt merged 3 commits intohackforla:gh-pagesfrom
macho-catt merged 3 commits intohackforla:gh-pagesfrom
Conversation
|
From your project repository, check out a new branch and test the changes. |
abuna1985
suggested changes
Aug 29, 2021
Member
abuna1985
left a comment
There was a problem hiding this comment.
@mehmehmehlol Great job. Thank you for helping with the button implementation and working with me on a resolution to apply the style changes. I only have one request:
- It seems the class name in the
<a>isbtn-defualt. Please change it tobtn--defaultand commit/push your changes to update this pull request.
Thank you.
abuna1985
approved these changes
Aug 30, 2021
Member
There was a problem hiding this comment.
@mehmehmehlol I see the update and everything looks good on the Join page buttons. Great work! 🥳 🥳 🥳
Thank you for helping us with the system design implementation.
adrian-zaragoza
approved these changes
Aug 31, 2021
Member
adrian-zaragoza
left a comment
There was a problem hiding this comment.
These changes look good! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2165
What changes did you make and why did you make them ?
.btn--defaulton_buttons.scssfromwebsite/_sass/elementsafter inquiring @abuna1985Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied