Skip to content

Swap wins from using wins-data to _wins-data#2380

Merged
macho-catt merged 1 commit intohackforla:gh-pagesfrom
macho-catt:2146-swap-wins-json
Oct 26, 2021
Merged

Swap wins from using wins-data to _wins-data#2380
macho-catt merged 1 commit intohackforla:gh-pagesfrom
macho-catt:2146-swap-wins-json

Conversation

@macho-catt
Copy link
Member

Fixes #2146

What changes did you make and why did you make them ?

  • The JS file for showing the wins entry data now uses _wins-data.json instead of wins-data.json

Screenshots to show wins page still looks the same

Visuals before changes are applied

wins-before

Visuals after changes are applied (no change)

wins-after

@github-actions github-actions bot added P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers Complexity: Medium status: Updated No blockers and update is ready for review labels Oct 20, 2021
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b macho-catt-2146-swap-wins-json gh-pages
git pull https://github.com/macho-catt/website.git 2146-swap-wins-json

@macho-catt
Copy link
Member Author

@abuna1985 @blakes24 since this is a file swap, I would like two pairs of eyes to sanity check the wins page and ensure that it still works and functions the same. Thanks!

@macho-catt
Copy link
Member Author

Wins page looks good after changes, so I will merge

@macho-catt macho-catt merged commit f5407f9 into hackforla:gh-pages Oct 26, 2021
@macho-catt macho-catt deleted the 2146-swap-wins-json branch November 6, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers status: Updated No blockers and update is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Wins Data: Migrating from AF to KVF data structure

1 participant