Skip to content

Update how 'Overview' link opens for Civic Tech Index#2507

Merged
macho-catt merged 1 commit intohackforla:gh-pagesfrom
JimGeist:update-overview-link-open-civic-tech-2237
Nov 22, 2021
Merged

Update how 'Overview' link opens for Civic Tech Index#2507
macho-catt merged 1 commit intohackforla:gh-pagesfrom
JimGeist:update-overview-link-open-civic-tech-2237

Conversation

@JimGeist
Copy link
Contributor

@JimGeist JimGeist commented Nov 21, 2021

Fixes #2237

What changes did you make and why did you make them ?

  • Created a copy of Civic-Tech-Index-Product-One-Sheet.pdf and placed the pdf in folder assets/pdfs/.
  • Updated 'Overview' link in file _projects/civic-tech-index.md to use url ../assets/pdfs/Civic-Tech-Index-Product-One-Sheet.pdf.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

…rla.org/assets/pdfs/' instead of 'github.com/hackforla/product-management/blob/master/project-one-sheets/'.
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b JimGeist-update-overview-link-open-civic-tech-2237 gh-pages
git pull https://github.com/JimGeist/website.git update-overview-link-open-civic-tech-2237

@github-actions github-actions bot added Feature: Refactor HTML role: front end Tasks for front end developers Size: Good second issue time sensitive Needs to be worked on by a particular timeframe labels Nov 22, 2021
@glenflorendo glenflorendo self-requested a review November 22, 2021 00:34
Copy link
Member

@glenflorendo glenflorendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work.

Copy link
Member

@macho-catt macho-catt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Good job!

@macho-catt macho-catt merged commit 84777a9 into hackforla:gh-pages Nov 22, 2021
@JimGeist JimGeist deleted the update-overview-link-open-civic-tech-2237 branch December 12, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update how 'Overview' link opens for Civic Tech Index

4 participants