Skip to content

remove-languages-2487#2575

Merged
macho-catt merged 1 commit intohackforla:gh-pagesfrom
anthonysim:remove-languages-2487
Dec 15, 2021
Merged

remove-languages-2487#2575
macho-catt merged 1 commit intohackforla:gh-pagesfrom
anthonysim:remove-languages-2487

Conversation

@anthonysim
Copy link
Member

Fixes #2487

What changes did you make and why did you make them ?

  • went through each .md file under the _projects collection directory and remove any instances of a language under the 'technologies' property
  • Removed TypeScript, Python, SCSS, and SASS wherever possible
  • Ensured that both the projects page and each individual project's landing page no longer has any of the mentioned languages under 'Technologies'
  • Ensure that the filter under the projects page no longer lists any of the mentioned languages as a possible filter option

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied
Visuals after changes are applied

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b anthonysim-remove-languages-2487 gh-pages
git pull https://github.com/anthonysim/website.git remove-languages-2487

@github-actions github-actions bot added P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue status: To Update! No update has been provided labels Dec 11, 2021
Copy link
Member

@lopezpedres lopezpedres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @anthonysim! It all looks good.

@JessicaLucindaCheng
Copy link
Member

@anthonysim Could you add your pull request to the Project Board? Thank you.

@anthonysim
Copy link
Member Author

@anthonysim Could you add your pull request to the Project Board? Thank you.

@JessicaLucindaCheng, sure I'll do that right now.

Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthonysim Changes look good to me! Fantastic job!

Copy link
Member

@macho-catt macho-catt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers status: To Update! No update has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove languages from the technologies field for each project

4 participants