Adds projects onto homepage with filters#261
Adds projects onto homepage with filters#261StephenVNelson wants to merge 26 commits intohackforla:gh-pagesfrom
Conversation
fix size and aspect ratio of not today image (hackforla#166)
…ust the projects page so the project page can be added later.
…ate page from fork
|
The filters work and I think this is an excellent feature to add to the homepage. Before merging it into master, I would love to see a couple of UI items addressed.
|
Sorry I think I misunderstood the comment. |
|
It only says Sort By because I followed the wireframes exactly. It's more
of an error than a decision to sort over filtering.
…On Mon, Feb 10, 2020 at 7:02 PM Kegan Maher ***@***.***> wrote:
1. This isn't sorting, it is filtering. Could we change "Sort by" to
"Filter by"?
Or can we change the behavior? The original Issue called for filtering,
was there a decision to go with sorting instead? Seems like filtering might
be more useful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#261?email_source=notifications&email_token=AE73J5IC7VYJM2HO47L5V43RCIIMDA5CNFSM4KGNXB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELLCPSQ#issuecomment-584460234>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE73J5K36O46YMPU6N2IBRTRCIIMDANCNFSM4KGNXB4Q>
.
--
Stephen V. Nelson
208-891-8492
|
|
@StephenVNelson
|
|
This gave us a starting place but is being superceded by work in #566 so I am going to close this. |

Pull request resolves #254