Skip to content

changing bold to strong#2718

Merged
JessicaLucindaCheng merged 1 commit intohackforla:gh-pagesfrom
blulady:2431_change_bold
Jan 27, 2022
Merged

changing bold to strong#2718
JessicaLucindaCheng merged 1 commit intohackforla:gh-pagesfrom
blulady:2431_change_bold

Conversation

@blulady
Copy link
Member

@blulady blulady commented Jan 26, 2022

Fixes #2431

What changes did you make and why did you make them ?

-changed b tags to strong tags
-to be compliant with Accessibility

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changed bold to strong. No visual changes to the website. tag -->

Details Images look the same with code change. Not Applied.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b blulady-2431_change_bold gh-pages
git pull https://github.com/blulady/website.git 2431_change_bold

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers labels Jan 26, 2022
@lindseyindev lindseyindev self-requested a review January 26, 2022 02:58
@lindseyindev
Copy link
Member

Availability: 1 hour
ETA: midnight 1/26

Copy link
Member

@lindseyindev lindseyindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You found that third tag not mentioned in the issue, great work!

@Georgema20
Copy link
Member

Availability: 1 hour
ETA: midnight 1/26

@Georgema20
Copy link
Member

Everything looks great except your screenshot of the website before and after do not work for me? Does it work for you? Can you put in a new after and a new before? Once I see that I can approve. Everything else looks great.

@JessicaLucindaCheng
Copy link
Member

@blulady Under the screenshots section, if there are no visual changes, you can just write no visual changes and then an explanation why there are no visual changes. (For more info, see this: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#iv-complete-pull-request-4-include-images-if-available)

@blulady
Copy link
Member Author

blulady commented Jan 27, 2022

Everything looks great except your screenshot of the website before and after do not work for me? Does it work for you? Can you put in a new after and a new before? Once I see that I can approve. Everything else looks great.

Hey George,
Because there were no visual changes, there were no images. I made the corrections suggested by Jessica in the comments.
Thank You!!

Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blulady Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility: Change bold to strong in join-us.html

4 participants