changing bold to strong#2718
changing bold to strong#2718JessicaLucindaCheng merged 1 commit intohackforla:gh-pagesfrom blulady:2431_change_bold
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 1 hour |
lindseyindev
left a comment
There was a problem hiding this comment.
Looks good! You found that third tag not mentioned in the issue, great work!
|
Availability: 1 hour |
|
Everything looks great except your screenshot of the website before and after do not work for me? Does it work for you? Can you put in a new after and a new before? Once I see that I can approve. Everything else looks great. |
|
@blulady Under the screenshots section, if there are no visual changes, you can just write no visual changes and then an explanation why there are no visual changes. (For more info, see this: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#iv-complete-pull-request-4-include-images-if-available) |
Hey George, |
JessicaLucindaCheng
left a comment
There was a problem hiding this comment.
@blulady Looks good to me!
Fixes #2431
What changes did you make and why did you make them ?
-changed b tags to strong tags
-to be compliant with Accessibility
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Changed bold to strong. No visual changes to the website. tag -->
Details
Images look the same with code change. Not Applied.