Update overview link 2240#2732
Merged
JessicaLucindaCheng merged 4 commits intohackforla:gh-pagesfrom Feb 4, 2022
Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
This comment was marked as outdated.
This comment was marked as outdated.
BrianCodes33
approved these changes
Feb 3, 2022
Contributor
BrianCodes33
left a comment
There was a problem hiding this comment.
I reviewed the files and everything looks good. Nicely done!
JessicaLucindaCheng
requested changes
Feb 3, 2022
Member
JessicaLucindaCheng
left a comment
There was a problem hiding this comment.
@Pauljsyi Good job on this issue! Could you please do the following?
- Please add your pull request to the project board.
- In the changes you made section, you wrote, "Updated markdown, html and js files regarding Expunge Assist overview url to point to a local directory containing the pdf file." However, in the Files changed tab, I only see the pdf being added and line 37 of the markdown file with changes. Could you edit and clarify in your post on what you meant in terms of updating html and js files?
JessicaLucindaCheng
approved these changes
Feb 4, 2022
Member
JessicaLucindaCheng
left a comment
There was a problem hiding this comment.
@Pauljsyi Looks good to me! Thanks for making those changes!
12 tasks
This was referenced Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #2240
What changes did you make and why did you make them ?
-Instead of the Overview link redirecting to a google docs page it opens the same file in pdf format stored locally.
-Updated markdown file regarding Expunge Assist overview url to point to a pdf file stored locally.
-Setting a standard on how pdf files should be opened.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied