Skip to content

Update overview link 2240#2732

Merged
JessicaLucindaCheng merged 4 commits intohackforla:gh-pagesfrom
Pauljsyi:update-overview-link-2240
Feb 4, 2022
Merged

Update overview link 2240#2732
JessicaLucindaCheng merged 4 commits intohackforla:gh-pagesfrom
Pauljsyi:update-overview-link-2240

Conversation

@Pauljsyi
Copy link
Member

@Pauljsyi Pauljsyi commented Feb 2, 2022

Fixes #2240

What changes did you make and why did you make them ?

-Instead of the Overview link redirecting to a google docs page it opens the same file in pdf format stored locally.
-Updated markdown file regarding Expunge Assist overview url to point to a pdf file stored locally.
-Setting a standard on how pdf files should be opened.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Update-Overview-Link-2240-before

Visuals after changes are applied

Update-Overview-Link-2240-after

@Pauljsyi Pauljsyi requested a review from daniellex0 February 2, 2022 19:58
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Pauljsyi-update-overview-link-2240 gh-pages
git pull https://github.com/Pauljsyi/website.git update-overview-link-2240

@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng requested review from JessicaLucindaCheng and removed request for daniellex0 February 3, 2022 00:32
@BrianCodes33 BrianCodes33 self-requested a review February 3, 2022 16:18
Copy link
Contributor

@BrianCodes33 BrianCodes33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the files and everything looks good. Nicely done!

Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pauljsyi Good job on this issue! Could you please do the following?

  1. Please add your pull request to the project board.

Add-to-project-board

  1. In the changes you made section, you wrote, "Updated markdown, html and js files regarding Expunge Assist overview url to point to a local directory containing the pdf file." However, in the Files changed tab, I only see the pdf being added and line 37 of the markdown file with changes. Could you edit and clarify in your post on what you meant in terms of updating html and js files?

Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pauljsyi Looks good to me! Thanks for making those changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update how 'Overview' link opens for Expunge Assist

4 participants