Skip to content

Not ready - do not review: Revert pr 2724 and pr 2672 #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JessicaLucindaCheng wants to merge 2 commits into from
Closed

Not ready - do not review: Revert pr 2724 and pr 2672 #2756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70753a0
Revert "Removed comments unrelated to pr 2672 from variables/_layout.…
JessicaLucindaCheng Feb 9, 2022
a26694c
Revert "Update tech dropdown 2397 (#2672)"
JessicaLucindaCheng Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 3 additions & 32 deletions _sass/components/_project-filter.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ a.filter-item {
//filter container
ul.filter-list {
background: $color-pink;
padding-left: 0;
list-style: none;
display: grid;
list-style: none;
padding-left: 0;
grid-auto-flow: column;
grid-column-gap: 20px;
// grid-template-columns: repeat(4, 1fr);
// ^ See issue #1997 for more info on why this is commented out and changed to 3
Expand Down Expand Up @@ -164,36 +165,6 @@ a.clear-filter-tags {
ul.filter-list li ul {
width: 105%;
padding: 15px;
overflow: auto;
}
}
// tablet down
@media #{$bp-below-tablet} {
#technologies {
height: 370px;
overflow: auto;
}
}

// tablet up
@media #{$bp-tablet-up} {
#technologies {
display: grid;
grid-auto-flow: column; // flows the data from top to bottom rather than left to right
grid-template-rows: repeat(16, 1fr); // ensures the list is 16 rows
list-style: none;
left: -17em;
width: 718px;
height: 380px;
overflow: auto;
}
}

// iPad Air to Desktop
@media #{$bp-desktop-up} {
#technologies {
left: -18em;
width: 768px;
}
}

Expand Down