Edited content field and removed type field from brochure.yml credits file#3159
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 10pm-11pm IST |
|
ETA: End of the day on 5/20 |
Jaretzbalba
left a comment
There was a problem hiding this comment.
@geedtd The code change in the brochure.yml looks good; however, I see that the docker-compose.yml file was changed which shouldn't have been. Based on the issue, it doesn't look like that file should be modified, so please undo that change, and everything should be good.
Thank you again for working on this and feel free to re-request a review when you're ready.
|
Hi @Jaretzbalba I reverted the docker file to it's original state, let me know if everything looks good. Thank you |
harshitasao
left a comment
There was a problem hiding this comment.
Hi @geedtd. Good job working on your first issue. The changes look good to me.
Jaretzbalba
left a comment
There was a problem hiding this comment.
@geedtd The changes look good and thank you for fixing the file!
Fixes #2796
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Changed iml file, no visual changes to website