Skip to content

Edited content field and removed type field from brochure.yml credits file#3159

Merged
tamara-snyder merged 2 commits intohackforla:gh-pagesfrom
geedtd:brochure-yml-credits-file-2796
May 20, 2022
Merged

Edited content field and removed type field from brochure.yml credits file#3159
tamara-snyder merged 2 commits intohackforla:gh-pagesfrom
geedtd:brochure-yml-credits-file-2796

Conversation

@geedtd
Copy link
Member

@geedtd geedtd commented May 19, 2022

Fixes #2796

What changes did you make and why did you make them ?

  • I edited line 4 changed the content field to content-type
  • deleted line 11 which was 'type: icon'

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changed iml file, no visual changes to website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b geedtd-brochure-yml-credits-file-2796 gh-pages
git pull https://github.com/geedtd/website.git brochure-yml-credits-file-2796

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels May 19, 2022
@harshitasao harshitasao self-requested a review May 19, 2022 08:00
@harshitasao
Copy link
Member

Availability: 10pm-11pm IST
Review ETA: 19/05/2022 (End of the day)

@Jaretzbalba Jaretzbalba self-requested a review May 19, 2022 15:49
@Jaretzbalba
Copy link
Member

ETA: End of the day on 5/20
Availability: 1 hours

Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geedtd The code change in the brochure.yml looks good; however, I see that the docker-compose.yml file was changed which shouldn't have been. Based on the issue, it doesn't look like that file should be modified, so please undo that change, and everything should be good.

Thank you again for working on this and feel free to re-request a review when you're ready.

@geedtd
Copy link
Member Author

geedtd commented May 19, 2022

Hi @Jaretzbalba I reverted the docker file to it's original state, let me know if everything looks good. Thank you

@geedtd geedtd requested a review from Jaretzbalba May 19, 2022 21:13
Copy link
Member

@harshitasao harshitasao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geedtd. Good job working on your first issue. The changes look good to me.

Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geedtd The changes look good and thank you for fixing the file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from brochure.yml credits file

4 participants