merging content and type to content-type in building.yml#3168
Merged
Jaretzbalba merged 1 commit intohackforla:gh-pagesfrom May 24, 2022
Merged
merging content and type to content-type in building.yml#3168Jaretzbalba merged 1 commit intohackforla:gh-pagesfrom
Jaretzbalba merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Member
|
ETA: End of the day on 5/23 |
Jaretzbalba
approved these changes
May 23, 2022
Member
Jaretzbalba
left a comment
Jaretzbalba
left a comment
There was a problem hiding this comment.
@mmogri The changes on the building.yml file look great! Thank you for working on this issue!
Member
|
ETA: End of the day on 5/23 |
kathrynsilvaconway
approved these changes
May 24, 2022
Member
kathrynsilvaconway
left a comment
kathrynsilvaconway
left a comment
There was a problem hiding this comment.
@mmogri Congrats on completing your first issue with Hack for LA. I see that you have changed the content field in line 4 to read 'content-type: image' and you have deleted line 11 from the building yml file. Nice work.
Member
|
ETA: End of day on 5/23 |
This was referenced Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2797
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied