Changed from Content to Content-Type#3297
Merged
kathrynsilvaconway merged 4 commits intohackforla:gh-pagesfrom Jun 26, 2022
Merged
Changed from Content to Content-Type#3297kathrynsilvaconway merged 4 commits intohackforla:gh-pagesfrom
kathrynsilvaconway merged 4 commits intohackforla:gh-pagesfrom
Conversation
clayton1111
added
good first issue
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Member
|
Review ETA: Less than 1 Hour |
Member
|
Avail: 1hr |
Member
|
Availability: 1 hour |
answebdev
reviewed
Jun 25, 2022
Member
answebdev
left a comment
answebdev
left a comment
There was a problem hiding this comment.
@clayton1111 Thank you for submitting your PR. For this issue, line 4 for the content field in _data/internal/credits/citizen-engagement.yml needed to be changed from content: image to content-type: image, and line 11 for the type field needed to be removed, which I can see that you did. Great job!
On a minor note: Please remove the white space in line 11 where the type field was removed. Currently, _data/internal/credits/citizen-engagement.yml has 12 lines, with 11 being empty. After removing this white space, you should then have 11 lines with no more white space. Thank you!
Sparky-code
approved these changes
Jun 25, 2022
Member
Sparky-code
left a comment
Sparky-code
left a comment
There was a problem hiding this comment.
Everything looks good, I see you've properly changed the requested lines. As soon as you've addressed the whitespace issue that @answebdev brought up you should be all set!
17 tasks
JessicaLucindaCheng
added a commit
to JessicaLucindaCheng/website
that referenced
this pull request
Jun 29, 2022
Used a squash and merge for this * Applied Title classes to heading elements on donate page (hackforla#2723) * applied Title classes to heading elements on donate page, repositioned first h1 element on page to align with paragraph. * changed Titlex classes to titlex, removed title classes from sass file. * fixed requested errors * Fixed the styling issues, localhost and hfla site match. * made requested changes * commiting changes so I can sync with upstream. * made requested changes * Removed Ready for milestone for Pre-work Template - Developers Reason: Tech leads should manually check the preworks before adding ready for milestone label * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update issue templates * Update meeting data * Update contributor and language data * Edited the content field and removed the type field so that redundant code is removed and the code is easier to understand (hackforla#3182) Merged hackforla#3182 into gh-pages. * Remove alt-hero field from civic-opportunity-project.md project file hackforla#2923 (hackforla#3173) * Update meeting data * Update contributor and language data * Update pre-work-template--dev.md (hackforla#3192) * Update dev prework template * Update pre-work-template---design.md (hackforla#3184) Bonnie asked to update the design template * Updated dev prework template * Update dev prework template * Update meeting data * Update contributor and language data * Update issue templates Updated estimates, time spent so far and progress report items. * Update CONTRIBUTING.md Added a note about leaving issues (other than pre-work) in In progress column until merged. * Fixed Project md file: Removing unused `alt-hero` field * Fix Alt Text Audit - Design issue template I did not make edits as part of commit fd642a4 to .github/ISSUE_TEMPLATE/alt-text-audit---design.md but for some reason changes were made. I fixed it here by editing the file to change it back. * Update meeting data * Update contributor and language data * Edited content field and removed (hackforla#3193) Merged hackforla#3193 into gh-pages. * Update CONTRIBUTING.md Added link of a filtered project board for back end good first issues. * removed unused alt-hero field (hackforla#3178) Co-authored-by: Olanrewaju-Ak <you@example.com> * Update meeting data * Update contributor and language data * Updated Project Profile Card review and update template Capitalized GitHub in the links section * Updated Pre-work Template - Developers Changed team lead to technical lead * Update issue templates (hackforla#3219) updated developer prework template * edit content field and remove type field from _data/interal/credits/resume.yml (hackforla#3218) * Update README.md * Remove alt-text field in github-issues.html, responsible-use-of-images-on-opensource-projects.html, setting-up-1password-on-opensource-projects.html, all within the _guide-pages directory (hackforla#3176) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * removed unused filed (hackforla#3221) * Removed type field 2878 (hackforla#3185) * modified content field * removed type field * modified content field * removed type field * revert jekyll version * Update meeting data * Update contributor and language data * Update developer pre-work issues * Update meeting data * Update contributor and language data * Update image location sponsors 2458 (hackforla#2984) * update image location for sponsors * update image location for sponsors * update class logo img * update code in sponsors.hmtl * add scss to cfa logo in citizen-engagement page * Remove alt hero field 3215 (hackforla#3231) * Docker-compose file update * Reverted docker-compose file from '4.2.0' back to 'pages' * alt-hero field deleted * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * remove unused alt field from vrms.md project file (hackforla#3226) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Lucky parking 2916 (hackforla#3086) * changed the spelling from webapp to web app on line 56 * chnaged the double quotes around the links to single quotes * Update meeting data * Update meeting data * Update contributor and language data * Update dev prework issue template * Update meeting data * Update contributor and language data * Add h tags 2952 (hackforla#3237) * add civic tech overview page to assets folder * change link in markdown file * Update merge conflict * Change p tags to h tags * Removed the alt text for the 311 project card image (hackforla#3241) to adhere to WCAG. * Update meeting data * Update contributor and language data * added a new note in section 2.2 before the existing one (hackforla#3235) Co-authored-by: Olanrewaju-Ak <you@example.com> * update project profile of home unite us page (hackforla#3162) * removed Abiha Ali and added Ben Ross under leadership for home unite us page * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * updated calendar-time.yml (hackforla#3258) Co-authored-by: olivi <olivia.yin.wang8@gmail.com> * Update meeting data * Update contributor and language data * Removed credits type field and renamed content to content-type in redo.yml (hackforla#3285) * Update meeting data * Update contributor and language data * Updated how 'overview' link opens for Home Unite US (hackforla#3224) * Updated how 'overview' link opens for Home Unite US * Update meeting data * Update contributor and language data * removed unused filed (hackforla#3221) * Removed type field 2878 (hackforla#3185) * modified content field * removed type field * modified content field * removed type field * revert jekyll version * Updated how 'overview' link opens for Home Unite US Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Arpita <66761308+arpitapandya@users.noreply.github.com> * changed line 4 for the content field from content:icon to content-type:image. Also removed line 11 type:icon (hackforla#3264) * Update meeting data * Update contributor and language data * Changed sdg image's alt text for access the data (hackforla#3288) * Resolve issue 2155 to add a comment reminding new issue assignees to add their ETA and availability (hackforla#2962) * changed content and type into one field: content-type (hackforla#3291) Co-authored-by: tunglinn <tunglin@yahoo.com> * update instructions template 2897 (hackforla#3262) Co-authored-by: olivi <olivia.yin.wang8@gmail.com> * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Updated website team members (hackforla#3298) * Changed from Content to Content-Type (hackforla#3297) * changed from content to content type * ignore * Change content to content-type * edited and removed words (hackforla#3287) Co-authored-by: Lily Arjomand <lilyarjomand@Lilys-MacBook-Pro.local> * Update meeting data * Update contributor and language data * Bump node-fetch from 2.6.1 to 2.6.7 in /github-actions/github-data (hackforla#3263) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * changed line 4 and deleted line 11 (hackforla#3303) Co-authored-by: Riya Aswani <riya@Riyas-MacBook-Air.local> * Update meeting data * Update contributor and language data * Changed alt text for card image (hackforla#3304) Co-authored-by: Lily Arjomand <lilyarjomand@Lilys-MacBook-Pro.local> * Update issue templates * Update meeting data * Update contributor and language data * changed image alt in lucky-parking.md (hackforla#3317) Co-authored-by: tunglinn <tunglin@yahoo.com> * Change alt text for citizen engagement html file (hackforla#3320) * changed from content to content type * change content to content-type * change content to content-type * change content to content-type * change content to content-type * change alt text line 52 * reset docker-compose Co-authored-by: Patrick McGuigan <74014488+pattshreds@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: alan-zambrano <41409431+alan-zambrano@users.noreply.github.com> Co-authored-by: mmogri <mmogri@users.noreply.github.com> Co-authored-by: Ava Li <62368440+Aveline-art@users.noreply.github.com> Co-authored-by: phuonguvan <100561599+phuonguvan@users.noreply.github.com> Co-authored-by: Saumil Dhankar <saumil.dhankar@yahoo.com> Co-authored-by: mchavezm <mchavezm451@gmail.com> Co-authored-by: Akinola Olanrewaju <103976465+Olanrewaju-Ak@users.noreply.github.com> Co-authored-by: Olanrewaju-Ak <you@example.com> Co-authored-by: Bonnie Wolfe <37763229+ExperimentsInHonesty@users.noreply.github.com> Co-authored-by: Don Brower <donald.brower1@gmail.com> Co-authored-by: Julian Smith <arieljeansmith@gmail.com> Co-authored-by: Arpita <66761308+arpitapandya@users.noreply.github.com> Co-authored-by: Jason Yee <42814942+JasonY188@users.noreply.github.com> Co-authored-by: Matthew Arofin <98365396+matt-arofin@users.noreply.github.com> Co-authored-by: Erick Odero <84427589+eodero@users.noreply.github.com> Co-authored-by: riddle015 <hiramriddle@gmail.com> Co-authored-by: Trisha Johnson <66317088+trishajjohnson@users.noreply.github.com> Co-authored-by: Olivia Wang <105330997+oliviaywangn@users.noreply.github.com> Co-authored-by: olivi <olivia.yin.wang8@gmail.com> Co-authored-by: Beckett OBrien <44044350+BeckettOBrien@users.noreply.github.com> Co-authored-by: Utkarsh Saboo <44554270+usaboo@users.noreply.github.com> Co-authored-by: Tung Lin <86996158+tunglinn@users.noreply.github.com> Co-authored-by: tunglinn <tunglin@yahoo.com> Co-authored-by: Clayton Brossia <107889868+clayton1111@users.noreply.github.com> Co-authored-by: Lily Arjomand <103547011+lilyarj@users.noreply.github.com> Co-authored-by: Lily Arjomand <lilyarjomand@Lilys-MacBook-Pro.local> Co-authored-by: Sarah Sanger <ssanger2020@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Riya Aswani <107890343+raswani2023@users.noreply.github.com> Co-authored-by: Riya Aswani <riya@Riyas-MacBook-Air.local>
This was referenced Aug 10, 2025
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2811
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No screenshot, does not change website visuals