Skip to content

Edit content field and remove type field from schedule.yml credits file#3369

Merged
Wny-Duong merged 2 commits intohackforla:gh-pagesfrom
seantokuzo:edit-yml-fields-2875
Jul 14, 2022
Merged

Edit content field and remove type field from schedule.yml credits file#3369
Wny-Duong merged 2 commits intohackforla:gh-pagesfrom
seantokuzo:edit-yml-fields-2875

Conversation

@seantokuzo
Copy link
Member

Fixes #2875

What changes did you make and why did you make them ?

  • In the file: website/_data/internal/credits/schedule.yml
  • Changed the 'content' field to 'content-type'
  • Removed the 'type' field
  • Changes were made following instruction from issue - reduce redundancy with these fields

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b seantokuzo-edit-yml-fields-2875 gh-pages
git pull https://github.com/seantokuzo/hack4la-website.git edit-yml-fields-2875

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jul 14, 2022
@Wny-Duong Wny-Duong self-requested a review July 14, 2022 05:05
@Wny-Duong
Copy link
Member

Availability: 2 hours
ETA: 7/14/22

Copy link
Member

@Wny-Duong Wny-Duong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to tweak line 4. From the original issue, you're meant to change it to:

content-type: image

But your change made it:

content-type: icon

@seantokuzo
Copy link
Member Author

Ah shoots I missed that. Should be updated now.

@lilyarj lilyarj requested review from lilyarj July 14, 2022 18:01
Copy link
Member

@Wny-Duong Wny-Duong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change. Looks good!

@Wny-Duong Wny-Duong merged commit e611046 into hackforla:gh-pages Jul 14, 2022
@seantokuzo seantokuzo deleted the edit-yml-fields-2875 branch August 9, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from schedule.yml credits file

2 participants