Skip to content

changed tags for getting started page#3375

Merged
blulady merged 1 commit intohackforla:gh-pagesfrom
arpitapandya:getting-started-page-2953
Jul 18, 2022
Merged

changed tags for getting started page#3375
blulady merged 1 commit intohackforla:gh-pagesfrom
arpitapandya:getting-started-page-2953

Conversation

@arpitapandya
Copy link
Member

@arpitapandya arpitapandya commented Jul 16, 2022

Fixes #2953

What changes did you make and why did you make them ?

  • In line 166, changed p tags with appropriate h tags
  • In line 201, changed p tags with appropriate h tags
  • Checked if its still looks same as per the Getting Started Page of Hack for LA

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

![image]

Visuals after changes are applied

![image](getting-started-page

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b arpitapandya-getting-started-page-2953 gh-pages
git pull https://github.com/arpitapandya/website.git getting-started-page-2953

@github-actions github-actions bot added P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Complexity: Small Take this type of issues after the successful merge of your second good first issue status: Updated No blockers and update is ready for review labels Jul 16, 2022
@Zak234 Zak234 self-requested a review July 17, 2022 05:13
Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the changes and compared the edits to the current page. Everything looked identical and should be working correctly.

@blulady blulady requested a review from tunglinn July 17, 2022 17:08
@tunglinn
Copy link
Member

ETA: today
Availability: 1hr

Copy link
Member

@tunglinn tunglinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge branches look good. Issue changes do not break or change the site. All issue changes are addressed. Good job!

Something I did notice on the original site is that Steps 3 and 4 are swapped in the Getting Started page.

  • on the top, Step 3 is Choose a Role, Step 4 is Adopt Our Standards
  • on the bottom, Step 3 is Adopt Our Standards, Step 4 is Choose a Role

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: Updated No blockers and update is ready for review

Projects

Development

Successfully merging this pull request may close these issues.

Add h tags to Getting Started page (Steps 4-5)

4 participants