Skip to content

Edited casing and attributes for clarity#3421

Merged
Wny-Duong merged 1 commit intohackforla:gh-pagesfrom
neevliberman:edit-content-field-2813
Jul 24, 2022
Merged

Edited casing and attributes for clarity#3421
Wny-Duong merged 1 commit intohackforla:gh-pagesfrom
neevliberman:edit-content-field-2813

Conversation

@neevliberman
Copy link
Member

@neevliberman neevliberman commented Jul 22, 2022

Fixes #2813

What changes did you make and why did you make them?

  • Changed content field to content-type
  • Removed type field
  • Changed casing of Image to image

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b neevliberman-edit-content-field-2813 gh-pages
git pull https://github.com/neevliberman/website.git edit-content-field-2813

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: Updated No blockers and update is ready for review labels Jul 22, 2022
@neevliberman
Copy link
Member Author

Provide Update

  1. Progress
    I managed to make the changes requested of me by the issue and Wilny Duong.
  2. Blockers
    I faced a pretty large blocker making this issue take about a week. This is a new issue copied from an old issue I had trouble with. For some reason, the branches I was creating become unable to be edited/closed/pushed to, which meant I couldn't update the pull request when needed. I troubleshooted, changed my origin and upstream, and left behind GitHub Desktop in favor of the command line and the Git wokrflow built into VSCode. However, I'm still unsure exactly what I'm doing so my second good issue will be a good way to test my knowledge. I also don't know to stage commits in VSCode yet, but I am learning.
  3. Availability
    50 minutes, then Sunday I will be mostly available.
  4. ETA
    Whenever the reviews come in! Maybe a few days?

@Zak234 Zak234 self-requested a review July 22, 2022 22:07
@lilyarj lilyarj self-requested a review July 22, 2022 23:03
@lilyarj
Copy link
Member

lilyarj commented Jul 22, 2022

ETA: 7/23
Availability: 3hrs

Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work!

Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: Updated No blockers and update is ready for review

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from contact.yml credits file

4 participants