Complete refactor/standardization of all buttons within Home Page #3422
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
Feature: Design system
Feature: Refactor HTML
P-Feature: Home page
|
Availability: 5 Hours |
BeckettOBrien
left a comment
BeckettOBrien
left a comment
There was a problem hiding this comment.
I don't have access to the google sheet linked in the issue but the changes are to the right lines of the right files and the site looks the same. Good job!
|
ETA: 7.24.22 |
|
Hey, was this the issue that you were showing us those slight visual variations on? If it is, could you grab some screenshots of the differences for documentation? |
|
I fixed those, it should look the same now. |
blulady
left a comment
blulady
left a comment
There was a problem hiding this comment.
The branches are correct. The linked issue is correct. The pr addresses the issues from the issue. There are a few lines that don't match the recommendation code, if you had to make these changes in order to get the code to look the same, I'll merge it but if it was an error let's update it. In line 4 of _includes/donate-button.html "btn--default" is left out from the recommendation code. There is a change on _includes/forms/contact-us.html that is not included in the recommended file
blulady
left a comment
blulady
left a comment
There was a problem hiding this comment.
Apparently you did need to make those changes.
3 participants
Fixes #2104
What changes did you make and why did you make them ?
-Made the 8 changes detailed in the issue which removed the button tag from donate-button.html, footer.html and contact-us.html. This was to help standardize the code.
-Changed the display for class btn--donate-footer from block to table so the donate button in the footer showed up correctly.
-Changed the display for class column from flex to block so that the Getting Started and Transport buttons were correctly formatted under their text.
-Added a new class in _cards.css called page-card-md-VWU and applied it to the Volunteer With Us card along with editing the volunteerWithUs class to give the card proper formatting and spacing.
-Edited the margin for btn--donate-header so that the donate button has proper spacing in the header
-Added padding for btn--donate-header when on smaller screens so that the text is properly displayed in the donate button.
-Commented code out in header-links as it was messing with the location of the donate button on smaller screens and the code was not observably affecting the other classes the class was applied to
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
None, the website should look the same.