Skip to content

Edit delegate fields 2815#3427

Merged
Wny-Duong merged 2 commits intohackforla:gh-pagesfrom
d-perez-8:edit-delegate-fields-2815
Jul 26, 2022
Merged

Edit delegate fields 2815#3427
Wny-Duong merged 2 commits intohackforla:gh-pagesfrom
d-perez-8:edit-delegate-fields-2815

Conversation

@d-perez-8
Copy link
Member

@d-perez-8 d-perez-8 commented Jul 25, 2022

Fixes #2815

What changes did you make and why did you make them?

  • The content field and the type field contain similar information, so removing the type field will remove the redundancy.
  • Changed the content field to content-type to have a clearer purpose.
  • Changed line 4 of the content field form from content: icon to content-type: image.
  • Removed line 11 type: icon.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Moving files to another directory. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b d-perez-8-edit-delegate-fields-2815 gh-pages
git pull https://github.com/d-perez-8/website.git edit-delegate-fields-2815

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jul 25, 2022
@BeckettOBrien BeckettOBrien self-requested a review July 25, 2022 19:38
@BeckettOBrien
Copy link
Member

Availability: 4 Hours
ETA: EOD 2022-07-25

@d-perez-8
Copy link
Member Author

Provide Update

  1. Progress: Finished, waiting for a review.
  2. Blockers: None
  3. Availability: Until 3 pm Pacific Time
  4. ETA: End of day

@arpitapandya arpitapandya self-requested a review July 25, 2022 19:53
@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-07-26

Copy link
Member

@BeckettOBrien BeckettOBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct and the site looks good. Good job!

@KBWells77 KBWells77 self-requested a review July 26, 2022 03:17
@KBWells77
Copy link
Member

Availability: 2 Hours
ETA: EOD 2022-07-25

Copy link
Member

@KBWells77 KBWells77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, everything looks correct in the code and on the website.

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good! Great job!! @d-perez-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from delegate.yml credits file

5 participants